summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* call: Fix error check on iconv's return value.Ralf Baechle2017-01-311-1/+1
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* listen: Fix comparison broken by limited range of types.Ralf Baechle2017-01-311-1/+1
| | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -O2 -Wall -Wextra -pedantic -MT utils.o -MD -MP -MF .deps/utils.Tpo -c -o utils.o utils.c utils.c: In function ‘lprintf’: utils.c:73:27: warning: comparison is always true due to limited range of data type [-Wtype-limits] || (*p > 126 && *p < 160 && sevenbit)) ^ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Sort out variable and function declarations.Ralf Baechle2017-01-3117-141/+186
| | | | | | | | | | - Make static what can be made static. - Add declaration where they were missing. - Don't define variables in headers. - Move declaations to the proper locations. - Pick up declarations from the proper headers. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Fix declaration of unix2yapp().Ralf Baechle2017-01-311-1/+1
| | | | | | It didn't match the actual function definition. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Fix further abuse of 0 as NULL pointer.Ralf Baechle2017-01-315-46/+46
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Fix argument of time() to time(NULL).Ralf Baechle2017-01-311-3/+3
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25mond: Switch version number printed to ax25-apps version.Ralf Baechle2017-01-231-1/+2
| | | | | | | | | | | The version number has not been changed ever since the oldest version of ax25-apps still available making it useless for bug reporting. Worse, using a symbol named VERSION is an autoconf-based package for anything but the autoconf-defined symbol is missleading. the version useless for bug reporting. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* gitignore: Ignore *~ files.Ralf Baechle2017-01-231-0/+1
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25ipd: Switch version number printed to ax25-apps version.Ralf Baechle2017-01-232-3/+1
| | | | | | | The version number has not been changed ever since ax25-apps 0.0.1 making the version useless for bug reporting. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25rtd: Delete useless declaration of variable Version.Ralf Baechle2017-01-231-2/+0
| | | | | | There only is a declaration, no definition. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Fix typo Documentatioa -> Documentation.Ralf Baechle2017-01-212-2/+2
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Remove definition for /proc/net/ax25_ports from pathnames.h.Ralf Baechle2017-01-191-1/+0
| | | | | | | | /proc/net/ax25_ports is a statistics file in invented for the NewAX25 stack. Nothing references PROC_AX25PORTS_FILE so just delete the definition. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Makefile.am: man page for ax25mond thought it's talking about "call"Thomas Osterried2016-11-161-2/+2
| | | | Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
* remove listen.1Thomas Osterried2016-07-041-105/+0
|
* Improved timestamps. With code and -t -tt -ttt ... option behaviour from ↵Thomas Osterried2016-07-041-2/+16
| | | | | | | | tcpdump. -> Without -t, listen now shows a timestamp. Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
* fixed segfault on -c option.root2016-07-041-2/+4
| | | | | | | has_colors() was called before initscr(). also added error message if terminal does not support colors (and then exit). Signed-off-by: root <root@db0fhn.ampr.org>
* Improved timestamps. With code and -t -tt -ttt ... option behaviour from ↵Thomas Osterried2016-07-044-22/+245
| | | | | | | | tcpdump. -> Without -t, listen now shows a timestamp. Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
* Merge branch 'master' of git://git.linux-ax25.org/pub/scm/ax25-appsThomas Osterried2016-03-141-0/+28
|\
| * listen -a shows on segmented packets ok, but shows also the defragmented,Thomas Osterried2016-03-121-0/+28
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | packet, but garbled: bpq2: fm DL9SAU to DL9SAU-15 ctl I00+ pid=8(segment) len 4 remain 0 0000 E2 E3 E4 | ... Reason: the defragmented packet is passed to netif_rx(skb). It has skb->protocol = htons(ETH_P_IP), but still belongs to ifr.ifr_hwaddr.sa_family == AF_AX25. listen -a looks for every iface with like ifr.ifr_hwaddr.sa_family == AF_AX25 and thus gets the desegmented packet. This desegmented packet has already lost his ax25 header information (it's the IP datagram that netif_rx sees), prefixed by AX25_P_IP = 0xcc: strace: recvfrom(3, "\0\210\230r\246\202\252\340\210\230r\246\202\252\177\314\10\201\314E\0\1\1\0\32\0\0?\1!\327,\200\200\n,\200\200\1\0\0\347\300\21\6\0\1\26\23\303V.. recvfrom(3, "\314E\0\1\1\0\32\0\0?\1!\327,\200\200\n,\200\200\1\0\0\347\300\21\6\0\1\26\23\303V.. \314 == 0xcc == AX25_P_IP We can make safely make the assumption for first byte == 0xcc and length > 2, that we safeley can detect those IP frames, and then ignore it. Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
* | call: Remove unused definition of MAXCMDLEN.Ralf Baechle2016-02-121-1/+0
| | | | | | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Have exactly one empty line following functions.Ralf Baechle2016-02-121-12/+3
| | | | | | | | | | | | Replace sequences of multiple empty lines to just one. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Move statline() to make declaration unnecessary.Ralf Baechle2016-02-121-42/+41
| | | | | | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Put statements following if() or while on separate line.Ralf Baechle2016-02-121-48/+85
| | | | | | | | | | | | Put while of do {} while loop on the line of the closing brace. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Have a blank separate a closing parenthesis and opening brace.Ralf Baechle2016-02-121-39/+39
| | | | | | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Avoid multiple statements or definitions in one line.Ralf Baechle2016-02-121-13/+28
| | | | | | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Don't use C++ comments.Ralf Baechle2016-02-121-81/+131
| | | | | | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Format with tabs instead of blanks.Ralf Baechle2016-02-121-133/+133
| | | | | | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Make static what can be made static.Ralf Baechle2016-02-121-31/+31
| | | | | | | | | | | | | | | | But leave remotecommand() to avoid a warning about the function being unused. It currently is unused because its sole caller is commented out. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Remove unused function writemsg().Ralf Baechle2016-02-121-30/+0
| | | | | | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Nuke trailing whitespace.Ralf Baechle2016-02-121-48/+48
| | | | | | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* | call: Remove initializations to 0 of global variables.Ralf Baechle2016-02-121-5/+5
|/ | | | | | | | C guarantees initialization to zero for global variables but putting those variables into the .bss section. An explicit initialization however will put the variable into the .data section where it will inflate the executable. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* UTF-8 support for call.Thomas Osterried2016-02-114-280/+771
| | | | | | | | | | | | | | | | | | | | | Patch by Cathryn Mataga. 1. Now supports UTF8 or IBM850 as the encoding style over AX25. 1a. Attention was paid to make sure that wide characters worked with East Asian fonts. 2. Now the screen can be resized. correctly. The program no longer crashes when it is resized. 3. Added a scrollback buffer. Use the up and down arrow keys or the page up/page down keys to scroll through history. After the screen begins scrolling, press 'up arrow' to view history. 4. Many visual quirks have been fixed. This version is now dependent on iconv and wide character versions of ncurses, which I think should be everywhere these days. Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
* call: Fix race condition between select(2) and signal delivery.Ralf Baechle2015-06-101-6/+13
| | | | | | | | | | | | | | If a signal is delivered between the start of the main select loop and select might wait for a long time. Fixing this with select is not possible so switch to pselect. Unlike select pselect akes a struct timespec pointer as its argument so rewrite the related infrastructure to work with struct timespec instead of struct timeval. For now the race did only affect the SIGQUIT delivery. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: The -T option is also supported for NET/ROM and ROSE.Ralf Baechle2015-06-101-2/+2
| | | | | | So document the fact. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Call: Fix typo in man page.Ralf Baechle2015-06-101-1/+1
| | | | | | automaticaly -> automatically Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Call: Fix parsing of the argument of the -T option.Ralf Baechle2015-06-101-9/+12
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Don't reinstall SIGQUIT signal handler.Ralf Baechle2015-06-101-1/+0
| | | | | | | This is Linux software so we don't have to deal with this kind of UNIX V7 or SVR3 braindamage of resetting the signal handlers. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Rewrite excessivly long select call for readability.Ralf Baechle2015-06-101-2/+9
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Harden against compiler overoptimization.Ralf Baechle2015-06-102-2/+2
| | | | | | | A compiler won't know that the interrupted variable can be changed behind its back in a signal handler so it might do clever overoptimizations. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Call: Handle select(2) returning EINTR.Ralf Baechle2015-06-102-5/+10
| | | | | | | | | | | | | | This may happen when call is running in curses mode, and the terminal window is resized which results in a SIGWINCH sent. Ncurses as normally configured on Linux distributions will have installed a handler. If as it is the most likely case, the select call will be interrupted by the signal, select will return EINTR and call will exit. Note that this doesn't mean it's now a good idea to resize the window. Call will still not handle the screen size change properly and the output will look ugly and missformatted. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25rtd: Fix signedness compiler warnings.Ralf Baechle2015-06-085-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Making all in ax25rtd make[2]: Entering directory '/home/ralf/src/ax25/ax25-apps/ax25rtd' [...] gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -g -O2 -Wall -MT cache_ctl.o -MD -MP -MF .deps/cache_ctl.Tpo -c -o cache_ctl.o cache_ctl.c cache_ctl.c: In function ‘update_ip_route’: cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:53:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:53:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:53:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:53:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:55:12: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c:109:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c: In function ‘update_ax25_route’: cache_ctl.c:133:25: warning: pointer targets in initialization differ in signedness [-Wpointer-sign] unsigned char *iface = config->dev; ^ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:142:27: warning: pointer targets in passing argument 1 of ‘del_kernel_ax25_route’ differ in signedness [-Wpointer-sign] del_kernel_ax25_route(bp->iface, ^ In file included from cache_ctl.c:28:0: ax25rtd.h:140:5: note: expected ‘char *’ but argument is of type ‘unsigned char *’ int del_kernel_ax25_route(char *dev, ax25_address *call); ^ cache_ctl.c:145:12: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c:145:23: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c:197:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c:197:20: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c: In function ‘remove_ip_route’: cache_ctl.c:231:22: warning: pointer targets in passing argument 1 of ‘del_kernel_ip_route’ differ in signedness [-Wpointer-sign] del_kernel_ip_route(bp->iface, bp->ip); ^ In file included from cache_ctl.c:28:0: ax25rtd.h:139:5: note: expected ‘char *’ but argument is of type ‘unsigned char *’ int del_kernel_ip_route(char *dev, long ip); ^ cache_ctl.c: In function ‘remove_ax25_route’: cache_ctl.c:255:24: warning: pointer targets in passing argument 1 of ‘del_kernel_ax25_route’ differ in signedness [-Wpointer-sign] del_kernel_ax25_route(bp->iface, &bp->call); ^ In file included from cache_ctl.c:28:0: ax25rtd.h:140:5: note: expected ‘char *’ but argument is of type ‘unsigned char *’ int del_kernel_ax25_route(char *dev, ax25_address *call); ^ cache_ctl.c: In function ‘del_ax25_route’: cache_ctl.c:297:10: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:297:10: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ cache_ctl.c:297:10: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:297:10: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ cache_ctl.c:297:10: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:297:10: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:297:10: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ cache_ctl.c:297:10: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:297:10: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ cache_ctl.c:297:10: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ [...] gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -g -O2 -Wall -MT cache_dump.o -MD -MP -MF .deps/cache_dump.Tpo -c -o cache_dump.o cache_dump.c cache_dump.c: In function ‘dump_ip_routes’: cache_dump.c:48:8: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] dev = bp->iface; ^ cache_dump.c:51:28: warning: pointer targets in passing argument 1 of ‘dev_get_config’ differ in signedness [-Wpointer-sign] config = dev_get_config(bp->iface); ^ In file included from cache_dump.c:33:0: ax25rtd.h:147:10: note: expected ‘char *’ but argument is of type ‘unsigned char *’ config * dev_get_config(char *dev); ^ cache_dump.c:55:9: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] dev = bp->iface; ^ cache_dump.c: In function ‘dump_ax25_routes’: cache_dump.c:92:8: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] dev = bp->iface; ^ cache_dump.c:95:28: warning: pointer targets in passing argument 1 of ‘dev_get_config’ differ in signedness [-Wpointer-sign] config = dev_get_config(bp->iface); ^ In file included from cache_dump.c:33:0: ax25rtd.h:147:10: note: expected ‘char *’ but argument is of type ‘unsigned char *’ config * dev_get_config(char *dev); ^ cache_dump.c:99:9: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] dev = bp->iface; ^ [...] gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -g -O2 -Wall -MT config.o -MD -MP -MF .deps/config.Tpo -c -o config.o config.c config.c: In function ‘interpret_command’: config.c:554:22: warning: pointer targets in passing argument 1 of ‘prepare_cmdline’ differ in signedness [-Wpointer-sign] p = prepare_cmdline(buf); ^ config.c:68:7: note: expected ‘char *’ but argument is of type ‘unsigned char *’ char *prepare_cmdline(char *buf) ^ config.c: In function ‘load_cache’: config.c:687:25: warning: pointer targets in passing argument 2 of ‘interpret_command’ differ in signedness [-Wpointer-sign] interpret_command(2, buf); ^ config.c:544:6: note: expected ‘unsigned char *’ but argument is of type ‘char *’ void interpret_command(int fd, unsigned char *buf) ^ config.c:695:25: warning: pointer targets in passing argument 2 of ‘interpret_command’ differ in signedness [-Wpointer-sign] interpret_command(2, buf); ^ config.c:544:6: note: expected ‘unsigned char *’ but argument is of type ‘char *’ void interpret_command(int fd, unsigned char *buf) ^ [...] gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -g -O2 -Wall -MT ax25rtctl.o -MD -MP -MF .deps/ax25rtctl.Tpo -c -o ax25rtctl.o ax25rtctl.c ax25rtctl.c: In function ‘main’: ax25rtctl.c:320:18: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] len = sprintf(buf, "add ax25"); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:322:20: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] len += sprintf(buf + len, " %s", argv[k]); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:323:12: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buf + len, "\n"); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:326:16: warning: pointer targets in passing argument 2 of ‘wsock’ differ in signedness [-Wpointer-sign] wsock(sock, buf); ^ ax25rtctl.c:95:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’ static int wsock(int sock, char *s) ^ ax25rtctl.c:332:18: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] len = sprintf(buf, "add ip"); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:334:20: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] len += sprintf(buf + len, " %s", argv[k]); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:335:12: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buf + len, "\n"); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:338:16: warning: pointer targets in passing argument 2 of ‘wsock’ differ in signedness [-Wpointer-sign] wsock(sock, buf); ^ ax25rtctl.c:95:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’ static int wsock(int sock, char *s) ^ ax25rtctl.c:348:12: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buf, "del ax25 %s %s\n", argv[optind], ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:352:16: warning: pointer targets in passing argument 2 of ‘wsock’ differ in signedness [-Wpointer-sign] wsock(sock, buf); ^ ax25rtctl.c:95:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’ static int wsock(int sock, char *s) ^ ax25rtctl.c:358:12: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buf, "del ip %s\n", argv[optind]); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:361:16: warning: pointer targets in passing argument 2 of ‘wsock’ differ in signedness [-Wpointer-sign] wsock(sock, buf); ^ ax25rtctl.c:95:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’ static int wsock(int sock, char *s) ^ ax25rtctl.c:379:11: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buf, "expire %ld\n", when); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:380:15: warning: pointer targets in passing argument 2 of ‘wsock’ differ in signedness [-Wpointer-sign] wsock(sock, buf); ^ ax25rtctl.c:95:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’ static int wsock(int sock, char *s) ^ [...] make[2]: Leaving directory '/home/ralf/src/ax25/ax25-apps/ax25rtd' Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25ipd/process.c: Fix signedness compiler warnings.Ralf Baechle2015-06-081-1/+1
| | | | | | | | | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -DUSE_TERMIO -g -O2 - Wall -MT process.o -MD -MP -MF .deps/process.Tpo -c -o process.o process.c process.c: In function ‘do_beacon’: process.c:235:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(p, bc_text); /* add the text field */ ^ In file included from /usr/include/memory.h:29:0, from ax25ipd.h:52, from process.c:15: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* listen: Fix signedness compiler warnings.Ralf Baechle2015-06-085-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make[2]: Entering directory '/home/ralf/src/ax25/ax25-apps/listen' gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT listen.o -MD -MP -MF .deps/listen.Tpo -c -o listen.o listen.c listen.c: In function ‘ascii_dump’: listen.c:231:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncat’ differ in signedness [-Wpointer-sign] strncat(buf, &c, 1); ^ listen.c:231:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ listen.c: In function ‘hex_dump’: listen.c:282:8: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] data2 = data; ^ [...] gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT rosedump.o -MD -MP -MF .deps/rosedump.Tpo -c -o rosedump.o rosedump.c rosedump.c: In function ‘facility’: rosedump.c:331:9: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] factot = data; ^ rosedump.c:398:11: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] for (d = data, l = 0; l < lgaddcall; ^ rosedump.c:406:28: warning: pointer targets in passing argument 1 of ‘dump_ax25_call’ differ in signedness [-Wpointer-sign] dump_ax25_call(d, 7)); ^ rosedump.c:296:14: note: expected ‘unsigned char *’ but argument is of type ‘char *’ static char *dump_ax25_call(unsigned char *data, int l_data) ^ rosedump.c:410:28: warning: pointer targets in passing argument 1 of ‘dump_ax25_call’ differ in signedness [-Wpointer-sign] dump_ax25_call(d, 7)); ^ rosedump.c:296:14: note: expected ‘unsigned char *’ but argument is of type ‘char *’ static char *dump_ax25_call(unsigned char *data, int l_data) ^ rosedump.c:438:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(indorig, data, lgadind); ^ rosedump.c:438:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ rosedump.c:441:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(inddest, data, lgadind); ^ rosedump.c:441:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ rosedump.c:451:14: warning: pointer targets in passing argument 1 of ‘data_dump’ differ in signedness [-Wpointer-sign] data_dump(factot, lgtot, 1); ^ In file included from rosedump.c:11:0: listen.h:31:6: note: expected ‘unsigned char *’ but argument is of type ‘char *’ void data_dump(unsigned char *, int, int); ^ [...] gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT utils.o -MD -MP -MF .deps/utils.Tpo -c -o utils.o utils.c utils.c: In function ‘lprintf’: utils.c:49:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] for (p = str; *p != '\0'; p++) { ^ utils.c:71:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] for (p = str; *p != '\0'; p++) ^ [...] make[2]: Leaving directory '/home/ralf/src/ax25/ax25-apps/listen' Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* listen/opentracdump.c: Fix signedness compiler warnings.Ralf Baechle2015-06-081-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT opentracdump.o -MD -MP -MF .deps/opentracdump.Tpo -c -o opentracdump.o opentracdump.c opentracdump.c: In function ‘decode_origination’: opentracdump.c:70:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c:70:22: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c: In function ‘decode_entityid’: opentracdump.c:86:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c:86:23: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c: In function ‘decode_comment’: opentracdump.c:159:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(comment, element, element_len); ^ opentracdump.c:159:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_country’: opentracdump.c:195:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(country, element, 2); ^ opentracdump.c:195:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c:198:2: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(subdivision, element+2, element_len-2); ^ opentracdump.c:198:2: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_displayname’: opentracdump.c:211:5: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(displayname, element, element_len); ^ opentracdump.c:211:5: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_waypoint’: opentracdump.c:221:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(waypoint, element, element_len); ^ opentracdump.c:221:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_pathtrace’: opentracdump.c:255:23: warning: pointer targets in passing argument 1 of ‘extract_ssid’ differ in signedness [-Wpointer-sign] ssid = extract_ssid(callsign); ^ opentracdump.c:30:5: note: expected ‘unsigned char *’ but argument is of type ‘char *’ int extract_ssid(unsigned char *call) { ^ opentracdump.c: In function ‘decode_acreg’: opentracdump.c:315:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(nnumber, element, element_len); ^ opentracdump.c:315:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_maidenhead’: opentracdump.c:406:3: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(maidenhead, element, element_len); ^ opentracdump.c:406:3: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘opentrac_dump’: opentracdump.c:452:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(origin_call, "SENDER"); /* Listen doesn't tell us the sender */ ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Update ChangeLog.Ralf Baechle2015-06-061-0/+9
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* RPM: Fix warnings during package build.Ralf Baechle2015-05-281-1/+0
| | | | | | | | | | | | | | warning: File listed twice: /usr/share/doc/ax25-apps warning: File listed twice: /usr/share/doc/ax25-apps/COPYING.ax25ipd warning: File listed twice: /usr/share/doc/ax25-apps/HISTORY.ax25ipd warning: File listed twice: /usr/share/doc/ax25-apps/README.ax25ipd warning: File listed twice: /usr/share/doc/ax25-apps/README.ax25rtd warning: File listed twice: /usr/share/doc/ax25-apps/TODO.ax25rtd %doc doesn't only mark a file a doc file but also includes it in the the files packaged. So no point in listing it yet again. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* RPM: Include config files in rpm package.Ralf Baechle2015-05-281-1/+5
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25ipd: Fix grammar of bpether log message.Ralf Baechle2015-05-281-1/+2
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25ipd: Add support for all Linux-supported bit rates.Ralf Baechle2015-05-282-0/+87
| | | | | | | | | | | | | | | | | For all Linux-supported architectures this adds support for: 57600, 115200, 230400, 460800, 500000, 576000, 1000000, 1152000, 1500000, 2000000, 2500000, 3000000, 3500000 and 4000000 bits per second. For SPARC this also adds suport for 76800, 153600, 307200, 614400 and 921600 bits per second. As before 50, 75, 110, 134, 150, 200, 300, 600, 1200, 1800, 2400, 4800, 9600, 19200 and 38400 remain supported. Document supported speeds in the ax25ipd.conf(5) man page. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Ignore "compile" file.Ralf Baechle2015-05-181-0/+1
| | | | | | | | | | | | automake 1.14 will install this file into the top directory with "automake --add-missing" and complain if it's missing: $ automake configure.ac:10: error: required file './compile' not found configure.ac:10: 'automake --add-missing' can install 'compile' $ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>