summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* Call: Fix typo in man page.Ralf Baechle2015-06-101-1/+1
| | | | | | automaticaly -> automatically Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Call: Fix parsing of the argument of the -T option.Ralf Baechle2015-06-101-9/+12
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Don't reinstall SIGQUIT signal handler.Ralf Baechle2015-06-101-1/+0
| | | | | | | This is Linux software so we don't have to deal with this kind of UNIX V7 or SVR3 braindamage of resetting the signal handlers. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Rewrite excessivly long select call for readability.Ralf Baechle2015-06-101-2/+9
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Harden against compiler overoptimization.Ralf Baechle2015-06-102-2/+2
| | | | | | | A compiler won't know that the interrupted variable can be changed behind its back in a signal handler so it might do clever overoptimizations. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Call: Handle select(2) returning EINTR.Ralf Baechle2015-06-102-5/+10
| | | | | | | | | | | | | | This may happen when call is running in curses mode, and the terminal window is resized which results in a SIGWINCH sent. Ncurses as normally configured on Linux distributions will have installed a handler. If as it is the most likely case, the select call will be interrupted by the signal, select will return EINTR and call will exit. Note that this doesn't mean it's now a good idea to resize the window. Call will still not handle the screen size change properly and the output will look ugly and missformatted. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25rtd: Fix signedness compiler warnings.Ralf Baechle2015-06-085-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Making all in ax25rtd make[2]: Entering directory '/home/ralf/src/ax25/ax25-apps/ax25rtd' [...] gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -g -O2 -Wall -MT cache_ctl.o -MD -MP -MF .deps/cache_ctl.Tpo -c -o cache_ctl.o cache_ctl.c cache_ctl.c: In function ‘update_ip_route’: cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:53:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:53:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:53:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:53:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:53:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:55:12: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c:109:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c: In function ‘update_ax25_route’: cache_ctl.c:133:25: warning: pointer targets in initialization differ in signedness [-Wpointer-sign] unsigned char *iface = config->dev; ^ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 1 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:141:7: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] if (strcmp(bp->iface, iface)) { ^ cache_ctl.c:141:7: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:142:27: warning: pointer targets in passing argument 1 of ‘del_kernel_ax25_route’ differ in signedness [-Wpointer-sign] del_kernel_ax25_route(bp->iface, ^ In file included from cache_ctl.c:28:0: ax25rtd.h:140:5: note: expected ‘char *’ but argument is of type ‘unsigned char *’ int del_kernel_ax25_route(char *dev, ax25_address *call); ^ cache_ctl.c:145:12: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c:145:23: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c:197:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c:197:20: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(bp->iface, iface); ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ cache_ctl.c: In function ‘remove_ip_route’: cache_ctl.c:231:22: warning: pointer targets in passing argument 1 of ‘del_kernel_ip_route’ differ in signedness [-Wpointer-sign] del_kernel_ip_route(bp->iface, bp->ip); ^ In file included from cache_ctl.c:28:0: ax25rtd.h:139:5: note: expected ‘char *’ but argument is of type ‘unsigned char *’ int del_kernel_ip_route(char *dev, long ip); ^ cache_ctl.c: In function ‘remove_ax25_route’: cache_ctl.c:255:24: warning: pointer targets in passing argument 1 of ‘del_kernel_ax25_route’ differ in signedness [-Wpointer-sign] del_kernel_ax25_route(bp->iface, &bp->call); ^ In file included from cache_ctl.c:28:0: ax25rtd.h:140:5: note: expected ‘char *’ but argument is of type ‘unsigned char *’ int del_kernel_ax25_route(char *dev, ax25_address *call); ^ cache_ctl.c: In function ‘del_ax25_route’: cache_ctl.c:297:10: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:297:10: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ cache_ctl.c:297:10: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:297:10: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ cache_ctl.c:297:10: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:297:10: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ In file included from cache_ctl.c:21:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ cache_ctl.c:297:10: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ cache_ctl.c:297:10: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ cache_ctl.c:297:10: warning: pointer targets in passing argument 2 of ‘__builtin_strcmp’ differ in signedness [-Wpointer-sign] && !strcmp(config->dev, bp->iface)) { ^ cache_ctl.c:297:10: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ [...] gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -g -O2 -Wall -MT cache_dump.o -MD -MP -MF .deps/cache_dump.Tpo -c -o cache_dump.o cache_dump.c cache_dump.c: In function ‘dump_ip_routes’: cache_dump.c:48:8: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] dev = bp->iface; ^ cache_dump.c:51:28: warning: pointer targets in passing argument 1 of ‘dev_get_config’ differ in signedness [-Wpointer-sign] config = dev_get_config(bp->iface); ^ In file included from cache_dump.c:33:0: ax25rtd.h:147:10: note: expected ‘char *’ but argument is of type ‘unsigned char *’ config * dev_get_config(char *dev); ^ cache_dump.c:55:9: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] dev = bp->iface; ^ cache_dump.c: In function ‘dump_ax25_routes’: cache_dump.c:92:8: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] dev = bp->iface; ^ cache_dump.c:95:28: warning: pointer targets in passing argument 1 of ‘dev_get_config’ differ in signedness [-Wpointer-sign] config = dev_get_config(bp->iface); ^ In file included from cache_dump.c:33:0: ax25rtd.h:147:10: note: expected ‘char *’ but argument is of type ‘unsigned char *’ config * dev_get_config(char *dev); ^ cache_dump.c:99:9: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] dev = bp->iface; ^ [...] gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -g -O2 -Wall -MT config.o -MD -MP -MF .deps/config.Tpo -c -o config.o config.c config.c: In function ‘interpret_command’: config.c:554:22: warning: pointer targets in passing argument 1 of ‘prepare_cmdline’ differ in signedness [-Wpointer-sign] p = prepare_cmdline(buf); ^ config.c:68:7: note: expected ‘char *’ but argument is of type ‘unsigned char *’ char *prepare_cmdline(char *buf) ^ config.c: In function ‘load_cache’: config.c:687:25: warning: pointer targets in passing argument 2 of ‘interpret_command’ differ in signedness [-Wpointer-sign] interpret_command(2, buf); ^ config.c:544:6: note: expected ‘unsigned char *’ but argument is of type ‘char *’ void interpret_command(int fd, unsigned char *buf) ^ config.c:695:25: warning: pointer targets in passing argument 2 of ‘interpret_command’ differ in signedness [-Wpointer-sign] interpret_command(2, buf); ^ config.c:544:6: note: expected ‘unsigned char *’ but argument is of type ‘char *’ void interpret_command(int fd, unsigned char *buf) ^ [...] gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -g -O2 -Wall -MT ax25rtctl.o -MD -MP -MF .deps/ax25rtctl.Tpo -c -o ax25rtctl.o ax25rtctl.c ax25rtctl.c: In function ‘main’: ax25rtctl.c:320:18: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] len = sprintf(buf, "add ax25"); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:322:20: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] len += sprintf(buf + len, " %s", argv[k]); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:323:12: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buf + len, "\n"); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:326:16: warning: pointer targets in passing argument 2 of ‘wsock’ differ in signedness [-Wpointer-sign] wsock(sock, buf); ^ ax25rtctl.c:95:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’ static int wsock(int sock, char *s) ^ ax25rtctl.c:332:18: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] len = sprintf(buf, "add ip"); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:334:20: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] len += sprintf(buf + len, " %s", argv[k]); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:335:12: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buf + len, "\n"); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:338:16: warning: pointer targets in passing argument 2 of ‘wsock’ differ in signedness [-Wpointer-sign] wsock(sock, buf); ^ ax25rtctl.c:95:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’ static int wsock(int sock, char *s) ^ ax25rtctl.c:348:12: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buf, "del ax25 %s %s\n", argv[optind], ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:352:16: warning: pointer targets in passing argument 2 of ‘wsock’ differ in signedness [-Wpointer-sign] wsock(sock, buf); ^ ax25rtctl.c:95:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’ static int wsock(int sock, char *s) ^ ax25rtctl.c:358:12: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buf, "del ip %s\n", argv[optind]); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:361:16: warning: pointer targets in passing argument 2 of ‘wsock’ differ in signedness [-Wpointer-sign] wsock(sock, buf); ^ ax25rtctl.c:95:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’ static int wsock(int sock, char *s) ^ ax25rtctl.c:379:11: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buf, "expire %ld\n", when); ^ In file included from ax25rtctl.c:20:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ ax25rtctl.c:380:15: warning: pointer targets in passing argument 2 of ‘wsock’ differ in signedness [-Wpointer-sign] wsock(sock, buf); ^ ax25rtctl.c:95:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’ static int wsock(int sock, char *s) ^ [...] make[2]: Leaving directory '/home/ralf/src/ax25/ax25-apps/ax25rtd' Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25ipd/process.c: Fix signedness compiler warnings.Ralf Baechle2015-06-081-1/+1
| | | | | | | | | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -DUSE_TERMIO -g -O2 - Wall -MT process.o -MD -MP -MF .deps/process.Tpo -c -o process.o process.c process.c: In function ‘do_beacon’: process.c:235:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(p, bc_text); /* add the text field */ ^ In file included from /usr/include/memory.h:29:0, from ax25ipd.h:52, from process.c:15: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* listen: Fix signedness compiler warnings.Ralf Baechle2015-06-085-13/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | make[2]: Entering directory '/home/ralf/src/ax25/ax25-apps/listen' gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT listen.o -MD -MP -MF .deps/listen.Tpo -c -o listen.o listen.c listen.c: In function ‘ascii_dump’: listen.c:231:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncat’ differ in signedness [-Wpointer-sign] strncat(buf, &c, 1); ^ listen.c:231:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ listen.c: In function ‘hex_dump’: listen.c:282:8: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] data2 = data; ^ [...] gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT rosedump.o -MD -MP -MF .deps/rosedump.Tpo -c -o rosedump.o rosedump.c rosedump.c: In function ‘facility’: rosedump.c:331:9: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] factot = data; ^ rosedump.c:398:11: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] for (d = data, l = 0; l < lgaddcall; ^ rosedump.c:406:28: warning: pointer targets in passing argument 1 of ‘dump_ax25_call’ differ in signedness [-Wpointer-sign] dump_ax25_call(d, 7)); ^ rosedump.c:296:14: note: expected ‘unsigned char *’ but argument is of type ‘char *’ static char *dump_ax25_call(unsigned char *data, int l_data) ^ rosedump.c:410:28: warning: pointer targets in passing argument 1 of ‘dump_ax25_call’ differ in signedness [-Wpointer-sign] dump_ax25_call(d, 7)); ^ rosedump.c:296:14: note: expected ‘unsigned char *’ but argument is of type ‘char *’ static char *dump_ax25_call(unsigned char *data, int l_data) ^ rosedump.c:438:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(indorig, data, lgadind); ^ rosedump.c:438:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ rosedump.c:441:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(inddest, data, lgadind); ^ rosedump.c:441:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ rosedump.c:451:14: warning: pointer targets in passing argument 1 of ‘data_dump’ differ in signedness [-Wpointer-sign] data_dump(factot, lgtot, 1); ^ In file included from rosedump.c:11:0: listen.h:31:6: note: expected ‘unsigned char *’ but argument is of type ‘char *’ void data_dump(unsigned char *, int, int); ^ [...] gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT utils.o -MD -MP -MF .deps/utils.Tpo -c -o utils.o utils.c utils.c: In function ‘lprintf’: utils.c:49:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] for (p = str; *p != '\0'; p++) { ^ utils.c:71:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] for (p = str; *p != '\0'; p++) ^ [...] make[2]: Leaving directory '/home/ralf/src/ax25/ax25-apps/listen' Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* listen/opentracdump.c: Fix signedness compiler warnings.Ralf Baechle2015-06-081-10/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT opentracdump.o -MD -MP -MF .deps/opentracdump.Tpo -c -o opentracdump.o opentracdump.c opentracdump.c: In function ‘decode_origination’: opentracdump.c:70:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c:70:22: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c: In function ‘decode_entityid’: opentracdump.c:86:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c:86:23: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c: In function ‘decode_comment’: opentracdump.c:159:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(comment, element, element_len); ^ opentracdump.c:159:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_country’: opentracdump.c:195:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(country, element, 2); ^ opentracdump.c:195:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c:198:2: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(subdivision, element+2, element_len-2); ^ opentracdump.c:198:2: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_displayname’: opentracdump.c:211:5: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(displayname, element, element_len); ^ opentracdump.c:211:5: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_waypoint’: opentracdump.c:221:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(waypoint, element, element_len); ^ opentracdump.c:221:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_pathtrace’: opentracdump.c:255:23: warning: pointer targets in passing argument 1 of ‘extract_ssid’ differ in signedness [-Wpointer-sign] ssid = extract_ssid(callsign); ^ opentracdump.c:30:5: note: expected ‘unsigned char *’ but argument is of type ‘char *’ int extract_ssid(unsigned char *call) { ^ opentracdump.c: In function ‘decode_acreg’: opentracdump.c:315:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(nnumber, element, element_len); ^ opentracdump.c:315:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_maidenhead’: opentracdump.c:406:3: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(maidenhead, element, element_len); ^ opentracdump.c:406:3: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘opentrac_dump’: opentracdump.c:452:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(origin_call, "SENDER"); /* Listen doesn't tell us the sender */ ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Update ChangeLog.Ralf Baechle2015-06-061-0/+9
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* RPM: Fix warnings during package build.Ralf Baechle2015-05-281-1/+0
| | | | | | | | | | | | | | warning: File listed twice: /usr/share/doc/ax25-apps warning: File listed twice: /usr/share/doc/ax25-apps/COPYING.ax25ipd warning: File listed twice: /usr/share/doc/ax25-apps/HISTORY.ax25ipd warning: File listed twice: /usr/share/doc/ax25-apps/README.ax25ipd warning: File listed twice: /usr/share/doc/ax25-apps/README.ax25rtd warning: File listed twice: /usr/share/doc/ax25-apps/TODO.ax25rtd %doc doesn't only mark a file a doc file but also includes it in the the files packaged. So no point in listing it yet again. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* RPM: Include config files in rpm package.Ralf Baechle2015-05-281-1/+5
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25ipd: Fix grammar of bpether log message.Ralf Baechle2015-05-281-1/+2
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25ipd: Add support for all Linux-supported bit rates.Ralf Baechle2015-05-282-0/+87
| | | | | | | | | | | | | | | | | For all Linux-supported architectures this adds support for: 57600, 115200, 230400, 460800, 500000, 576000, 1000000, 1152000, 1500000, 2000000, 2500000, 3000000, 3500000 and 4000000 bits per second. For SPARC this also adds suport for 76800, 153600, 307200, 614400 and 921600 bits per second. As before 50, 75, 110, 134, 150, 200, 300, 600, 1200, 1800, 2400, 4800, 9600, 19200 and 38400 remain supported. Document supported speeds in the ax25ipd.conf(5) man page. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Ignore "compile" file.Ralf Baechle2015-05-181-0/+1
| | | | | | | | | | | | automake 1.14 will install this file into the top directory with "automake --add-missing" and complain if it's missing: $ automake configure.ac:10: error: required file './compile' not found configure.ac:10: 'automake --add-missing' can install 'compile' $ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* automake: Replace use of deprecated automake macro INCLUDES.Ralf Baechle2015-05-175-10/+10
| | | | | | | | | | | | | This fixes the automake warnings: Makefile.am:11: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') ax25ipd/Makefile.am:58: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') ax25mond/Makefile.am:46: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') ax25rtd/Makefile.am:89: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS') INCLUDES has been deprecated since automake 1.5. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Insert space between `)' and a following `{'.Ralf Baechle2015-05-021-1/+1
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Reformat consistently. Strictly whitespace changes only.Ralf Baechle2015-05-0210-453/+453
| | | | | | | Indentation by tabs only. Move case labels in switches are on the same level as the switch keyword. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Remove pointless return statements at the end of void functions.Ralf Baechle2015-05-023-6/+0
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Always have a space between if, for, switch, while and the following `('.Ralf Baechle2015-05-022-2/+2
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Remove parenthesis around arguments of return statements.Ralf Baechle2015-05-028-46/+46
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Use tabs for indentation, not spaces.Ralf Baechle2015-05-0210-113/+113
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Remove useless initializations to 0 or NULL.Ralf Baechle2015-05-023-13/+13
| | | | | | | They only inflate the .data section of the binary. Initializations to FALSE are still left to do. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Nuke trailing whitespace.Ralf Baechle2015-05-0234-121/+121
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Nuke trailing blank lines.Ralf Baechle2015-05-029-11/+0
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Fix accidental termination of ax25ipd.Thomas Osterried2015-05-021-0/+20
| | | | | | | | | | ax25ipd sometimes terminated ("normaly") when the remote site (or a router on the way) sent an icmp unreachable. That's a problem with a positive error list (where every unknown error is interpreted as major problem); this makes the code unstable whenever new errno's are implemented in newer kernels.. Signed-off-by: Thomas Osterried <thomas@osterried.de>
* Bump version to 0.0.8-rc4.ax25-apps-0.0.8-rc4Ralf Baechle2013-06-171-1/+1
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25ipd: Make LOGx() macros bulletproof.Ralf Baechle2013-06-173-4/+23
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The LOGL1..LOGL4 macros were defined like: Now consider an invocation like: if (condition) LOGL1(...); else something_different(); CPP will expand this like: if (condition) if (loglevel>0) syslog(LOG_DAEMON | LOG_WARNING, ...); else something_different(); That is the else would now be considered associated with the wrong if. Macro arguments may also not have been evaluated on every invocation making the use of these function-like looking macros not function like. For example: LOGL1("%d", i++); would be expanded to if (loglevel>0) syslog(LOG_DAEMON | LOG_WARNING, i++); That is depending on the value of loglevel i++ would only be incremented if syslog was actually being called. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Kill a ton of useless casts to char * all over the code.Ralf Baechle2013-06-175-19/+22
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25dump: Fix warning about set but not used variables.Ralf Baechle2013-06-171-0/+2
| | | | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -O2 -Wall -Wno-pointer-sign -MT ax25dump.o -MD -MP -MF .deps/ax25dump.Tpo -c -o ax25dump.o ax25dump.c ax25dump.c: In function ‘ax25_dump’: ax25dump.c:170:10: warning: ‘ns’ may be used uninitialized in this function [-Wmaybe-uninitialized] ax25dump.c:167:10: warning: ‘nr’ may be used uninitialized in this function [-Wmaybe-uninitialized] GCC isn't quite smart enough to figure out that this warning is bogus. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Fix warning about set but not used variable.Ralf Baechle2013-06-171-2/+2
| | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -O2 -Wall -Wno-pointer-sign -MT call.o -MD -MP -MF .deps/call.Tpo -c -o call.o call.c call.c: In function ‘wrdstatw’: call.c:482:9: warning: variable ‘x’ set but not used [-Wunused-but-set-variable] mv -f .deps/call.Tpo .deps/call.Po Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Fix warning about set but not used variable.Ralf Baechle2013-06-171-4/+2
| | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -O2 -Wall -Wno-pointer-sign -MT menu.o -MD -MP -MF .deps/menu.Tpo -c -o menu.o menu.c menu.c: In function ‘p_dwn_menu’: menu.c:132:15: warning: variable ‘pos’ set but not used [-Wunused-but-set-variable] menu.c: In function ‘top_menu’: menu.c:244:11: warning: variable ‘pos’ set but not used [-Wunused-but-set-variable] Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* call: Fix warning about set but unused variable.Ralf Baechle2013-06-171-2/+0
| | | | | | | call.c:1590:6: warning: variable ‘extrach’ set but not used [-Wunused-but-set-va riable] Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Fix warnings about set but not used variables.Ralf Baechle2013-06-171-8/+1
| | | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -O2 -Wall -Wno-pointer-sign -MT rosedump.o -MD -MP -MF .deps/rosedump.Tpo -c -o rosedump.o rosedump.c rosedump.c: In function ‘rose_dump’: rosedump.c:57:17: warning: variable ‘dest’ set but not used [-Wunused-but-set-va riable] rosedump.c:56:17: warning: variable ‘source’ set but not used [-Wunused-but-set- variable] rosedump.c: In function ‘facility’: rosedump.c:329:12: warning: variable ‘lgaddr’ set but not used [-Wunused-but-set -variable] Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Remove useless test that is always evaluated as true.Ralf Baechle2013-06-171-2/+2
| | | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_ LOCALSTATEDIR=\""/usr/local/var/ax25"\" -O2 -Wall -Wno-pointer-sign -MT list ener.o -MD -MP -MF .deps/listener.Tpo -c -o listener.o listener.c listener.c: In function ‘set_route’: listener.c:232:6: warning: the address of ‘iproute2_table’ will always evaluate as ‘true’ [-Waddress] listener.c: In function ‘del_kernel_ip_route’: listener.c:278:6: warning: the address of ‘iproute2_table’ will always evaluate as ‘true’ [-Waddress] Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25ipd: Remove useless casts of inet_ntoa() return values to char *.Ralf Baechle2013-06-161-4/+4
| | | | | | inet_ntoa() already returns char *. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* ax25ipd: Fix metric butload of type aliasing bugs.Ralf Baechle2013-06-161-7/+8
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Listen: Fix test for tty's color capabilities.Ralf Baechle2013-06-161-1/+1
| | | | | | | | | | It was testing the address of the curses function has_color(), not its return value indicated by the following warning: utils.c: In function ‘initcolor’: utils.c:84:6: warning: the address of ‘has_colors’ will always evaluate as ‘true’ [-Waddress] Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Weed out all use of RCS strings.Ralf Baechle2013-06-0516-36/+9
| | | | | | | Their value has always been dubious and git doesn't support them so let's get rid of the clutter. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Ignore generated distribution archives.Ralf Baechle2013-06-041-0/+8
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* List docfiles to be packaged in spec file.Ralf Baechle2013-06-041-0/+1
| | | | | | | | | | | | | This fixes this build error: error: Installed (but unpackaged) file(s) found: /usr/share/doc/ax25-apps/COPYING.ax25ipd /usr/share/doc/ax25-apps/HISTORY.ax25ipd /usr/share/doc/ax25-apps/README.ax25ipd /usr/share/doc/ax25-apps/README.ax25rtd /usr/share/doc/ax25-apps/TODO.ax25rtd Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Remove bogus removal of doc files.Ralf Baechle2013-06-041-3/+0
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Remove all definitions of docdir from makefiles.Ralf Baechle2013-06-042-2/+0
| | | | | | | This may result in docfiles getting installed in ${prefix}/doc/, not ${prefix}/share/doc which is the convention. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Remove generated file ltconfig.Ralf Baechle2013-06-042-3017/+1
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Ignore even more generated files.Ralf Baechle2013-06-046-37/+28
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Convert .cvsignore files to .gitignoreRalf Baechle2013-06-046-4/+4
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Bump version number to 0.0.8-rc3.ax25-apps-0.0.8-rc3ax25-apps-0.0.8-rc2Ralf Baechle2013-06-041-1/+1
|
* Remove generated man pages on make distclean.Ralf Baechle2013-06-043-0/+5
|
* Include man page source files in generated dist archives.Ralf Baechle2013-06-044-4/+4
|
generated by cgit v1.2.3 (git 2.25.1) at 2024-07-03 19:24:58 +0000