| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
fb9187cbfcbe ("ax25ipd: Switch version number printed to ax25-apps
version.") removed the VERS2 argument from printf but forgot to remove the
%s format string as well potencially crashing or printing garbage when
printing the version number.
Fixes: fb9187cbfcbe ("ax25ipd: Switch version number printed to ax25-apps version.")
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the following warnings:
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -g -O2 -Wall -MT io.o -MD -MP -MF .deps/io.Tpo -c -o io.o io.c
io.c: In function ‘io_open’:
io.c:324:18: warning: implicit declaration of function ‘ptsname’; did you mean ‘ttyname’? [-Wimplicit-function-declaration]
if ((namepts = ptsname(ttyfd)) == NULL) {
^~~~~~~
ttyname
io.c:324:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((namepts = ptsname(ttyfd)) == NULL) {
^
io.c:329:7: warning: implicit declaration of function ‘unlockpt’; did you mean ‘unlinkat’? [-Wimplicit-function-declaration]
if (unlockpt(ttyfd) == -1) {
^~~~~~~~
unlinkat
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
| |
We were including way too many system header files, some even multiple
times and it wasn't immediately visible. Clean this.
This also drops the definitions of __USE_XOPEN which never had the desired
effect with glibc.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
bzero is a mega-ancient use of bsdism.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
Supposedly it didn't work and it was never being built anyway.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
I don't think this was ever meant to run on a BSD/i386 or BSD/OS system.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
io_error() has no callers outside its defining file.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
make usr1_handler() static, remove its prototype from the header and reorder
code to avoid prototypes.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
There were two - and they can be avoided entirely.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
It's only being used from within ax25ipd.c. To avoid the need for a
prototype within ax25ipd.c move the function above its first caller.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
It's only being used from within ax25ipd.c.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The stats structure was defined in the ax25ipd.h header as a static variable
resulting in each compilation unit having its own stats variable. The
sole reader, the do_stats() function would thus only see and print all-zero
stats.
This also fixes the following warnings:
make[2]: Entering directory '/home/ralf/src/ax25/ax25-apps/ax25ipd'
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -DUSE_TERMIO -g -O2 -Wall -MT crc.o -MD -MP -MF .deps/crc.Tpo -c -o crc.o crc.c
In file included from crc.c:3:0:
ax25ipd.h:108:3: warning: ‘stats’ defined but not used [-Wunused-variable]
} stats;
^~~~~
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -DUSE_TERMIO -g -O2 -Wall -MT routing.o -MD -MP -MF .deps/routing.Tpo -c -o routing.o routing.c
In file included from routing.c:10:0:
ax25ipd.h:108:3: warning: ‘stats’ defined but not used [-Wunused-variable]
} stats;
^~~~~
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -DUSE_TERMIO -g -O2 -Wall -MT syslog.o -MD -MP -MF .deps/syslog.Tpo -c -o syslog.o syslog.c
In file included from syslog.c:4:0:
ax25ipd.h:108:3: warning: ‘stats’ defined but not used [-Wunused-variable]
} stats;
^~~~~
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -DUSE_TERMIO -g -O2 -Wall -MT bpqether.o -MD -MP -MF .deps/bpqether.Tpo -c -o bpqether.o bpqether.c
In file included from bpqether.c:39:0:
ax25ipd.h:108:3: warning: ‘stats’ defined but not used [-Wunused-variable]
} stats;
^~~~~
[...]
make[2]: Leaving directory '/home/ralf/src/ax25/ax25-apps/ax25ipd'
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
| |
- Make static what can be made static.
- Add declaration where they were missing.
- Don't define variables in headers.
- Move declaations to the proper locations.
- Pick up declarations from the proper headers.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
The version number has not been changed ever since ax25-apps 0.0.1 making
the version useless for bug reporting.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25"\" -DUSE_TERMIO -g -O2 -
Wall -MT process.o -MD -MP -MF .deps/process.Tpo -c -o process.o process.c
process.c: In function ‘do_beacon’:
process.c:235:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(p, bc_text); /* add the text field */
^
In file included from /usr/include/memory.h:29:0,
from ax25ipd.h:52,
from process.c:15:
/usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For all Linux-supported architectures this adds support for:
57600, 115200, 230400, 460800, 500000, 576000, 1000000, 1152000,
1500000, 2000000, 2500000, 3000000, 3500000 and 4000000 bits per second.
For SPARC this also adds suport for 76800, 153600, 307200, 614400 and
921600 bits per second.
As before 50, 75, 110, 134, 150, 200, 300, 600, 1200, 1800, 2400, 4800,
9600, 19200 and 38400 remain supported.
Document supported speeds in the ax25ipd.conf(5) man page.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the automake warnings:
Makefile.am:11: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
ax25ipd/Makefile.am:58: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
ax25mond/Makefile.am:46: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
ax25rtd/Makefile.am:89: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
INCLUDES has been deprecated since automake 1.5.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
Indentation by tabs only. Move case labels in switches are on the same
level as the switch keyword.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
They only inflate the .data section of the binary. Initializations to
FALSE are still left to do.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
| |
ax25ipd sometimes terminated ("normaly") when the remote site (or
a router on the way) sent an icmp unreachable.
That's a problem with a positive error list (where every unknown
error is interpreted as major problem); this makes the code
unstable whenever new errno's are implemented in newer kernels..
Signed-off-by: Thomas Osterried <thomas@osterried.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The LOGL1..LOGL4 macros were defined like:
Now consider an invocation like:
if (condition)
LOGL1(...);
else
something_different();
CPP will expand this like:
if (condition)
if (loglevel>0)
syslog(LOG_DAEMON | LOG_WARNING, ...);
else
something_different();
That is the else would now be considered associated with the wrong if.
Macro arguments may also not have been evaluated on every invocation
making the use of these function-like looking macros not function like.
For example:
LOGL1("%d", i++);
would be expanded to
if (loglevel>0)
syslog(LOG_DAEMON | LOG_WARNING, i++);
That is depending on the value of loglevel i++ would only be incremented if
syslog was actually being called.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
inet_ntoa() already returns char *.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
Their value has always been dubious and git doesn't support them so let's
get rid of the clutter.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
This may result in docfiles getting installed in ${prefix}/doc/, not
${prefix}/share/doc which is the convention.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
| |
|
| |
|
|
|
|
|
| |
the port configured with "socket udp <port>"; but you could still
specify another port with "route call ip udp anotherPort".
|
|
|
|
|
|
|
|
| |
Since the recent conversion from static to generated man pages some
man pages were generated with a wrong section suffix which was breaking
installation.
Noticed and fixed by Steffen Köhler <sk4@mail.zih.tu-dresden.de>.
|