From 868d75cd2bdb0545518c4b651aa3f8b5953954c5 Mon Sep 17 00:00:00 2001 From: Ralf Baechle Date: Sun, 7 Jun 2015 10:32:38 +0200 Subject: listen/opentracdump.c: Fix signedness compiler warnings. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT opentracdump.o -MD -MP -MF .deps/opentracdump.Tpo -c -o opentracdump.o opentracdump.c opentracdump.c: In function ‘decode_origination’: opentracdump.c:70:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c:70:22: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c: In function ‘decode_entityid’: opentracdump.c:86:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c:86:23: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(entity_call, origin_call); ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ opentracdump.c: In function ‘decode_comment’: opentracdump.c:159:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(comment, element, element_len); ^ opentracdump.c:159:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_country’: opentracdump.c:195:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(country, element, 2); ^ opentracdump.c:195:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c:198:2: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(subdivision, element+2, element_len-2); ^ opentracdump.c:198:2: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_displayname’: opentracdump.c:211:5: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(displayname, element, element_len); ^ opentracdump.c:211:5: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_waypoint’: opentracdump.c:221:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(waypoint, element, element_len); ^ opentracdump.c:221:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_pathtrace’: opentracdump.c:255:23: warning: pointer targets in passing argument 1 of ‘extract_ssid’ differ in signedness [-Wpointer-sign] ssid = extract_ssid(callsign); ^ opentracdump.c:30:5: note: expected ‘unsigned char *’ but argument is of type ‘char *’ int extract_ssid(unsigned char *call) { ^ opentracdump.c: In function ‘decode_acreg’: opentracdump.c:315:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(nnumber, element, element_len); ^ opentracdump.c:315:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘decode_maidenhead’: opentracdump.c:406:3: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign] strncpy(maidenhead, element, element_len); ^ opentracdump.c:406:3: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ opentracdump.c: In function ‘opentrac_dump’: opentracdump.c:452:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(origin_call, "SENDER"); /* Listen doesn't tell us the sender */ ^ In file included from opentracdump.c:9:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ Signed-off-by: Ralf Baechle --- listen/opentracdump.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'listen') diff --git a/listen/opentracdump.c b/listen/opentracdump.c index 88f4ac4..128cb9a 100644 --- a/listen/opentracdump.c +++ b/listen/opentracdump.c @@ -18,16 +18,16 @@ const char *units[]={"Volts","Amperes","Watts","Kelvins","Meters","Seconds", "Pascal Seconds","Kilograms/Meter^3","Radians/Second^2","Coulombs", "Farads","Siemens","Count"}; -unsigned char origin_call[7]; /* Who's talking */ +char origin_call[7]; /* Who's talking */ unsigned char origin_ssid; -unsigned char entity_call[7]; /* What they're talking about */ +char entity_call[7]; /* What they're talking about */ unsigned char entity_ssid; unsigned int entity_serial; unsigned int entity_sequence; -int extract_ssid(unsigned char *call) { +int extract_ssid(char *call) { /* Strip the SSID from the callsign and return it */ int c, ssid; @@ -156,7 +156,7 @@ int decode_comment(unsigned char *element, int element_len) { /* 0x12 Freeform Comment - ASCII text */ char comment[127]; - strncpy(comment, element, element_len); + strncpy(comment, (char *)element, element_len); comment[element_len] = 0; lprintf(T_OPENTRAC, "Text: %s\r\n", comment); @@ -192,10 +192,10 @@ int decode_country(unsigned char *element, int element_len) { char country[3]; char subdivision[4]; - strncpy(country, element, 2); + strncpy(country, (char *)element, 2); country[2] = 0; if (element_len > 2) { - strncpy(subdivision, element+2, element_len-2); + strncpy(subdivision, (char *)element+2, element_len-2); subdivision[element_len-2] = 0; lprintf(T_OPENTRAC, "Country Code %s-%s\r\n", country, subdivision); } @@ -208,7 +208,7 @@ int decode_country(unsigned char *element, int element_len) { int decode_displayname(unsigned char *element, int element_len) { char displayname[31]; /* 0x16 - Display Name (UTF-8 text) */ - strncpy(displayname, element, element_len); + strncpy(displayname, (char *)element, element_len); displayname[element_len] = 0; lprintf(T_OPENTRAC, "Display Name: %s\r\n", displayname); @@ -218,7 +218,7 @@ int decode_displayname(unsigned char *element, int element_len) { int decode_waypoint(unsigned char *element, int element_len) { char waypoint[7]; /* 0x17 - Waypoint Name (up to 6 chars, uppercase) */ - strncpy(waypoint, element, element_len); + strncpy(waypoint, (char *)element, element_len); waypoint[element_len] = 0; lprintf(T_OPENTRAC, "Waypoint Name: %s\r\n", waypoint); @@ -312,7 +312,7 @@ int decode_gpsquality(unsigned char *element, int element_len) { int decode_acreg(unsigned char *element, int element_len) { char nnumber[9]; /* 0x35 Aircraft Registration - ASCII text */ - strncpy(nnumber, element, element_len); + strncpy(nnumber, (char *)element, element_len); nnumber[element_len]=0; lprintf(T_OPENTRAC, "Aircraft ID: %s\r\n", nnumber); @@ -403,7 +403,7 @@ int decode_maidenhead(unsigned char *element, int element_len) { if (element_len > 6 || !element_len) return -1; - strncpy(maidenhead, element, element_len); + strncpy(maidenhead, (char *)element, element_len); maidenhead[element_len] = 0; lprintf(T_OPENTRAC, "Grid ID: %s\r\n", maidenhead); -- cgit v1.2.3