diff options
author | Ralf Baechle <ralf@linux-mips.org> | 2017-08-02 23:25:13 +0200 |
---|---|---|
committer | Ralf Baechle <ralf@linux-mips.org> | 2017-08-03 04:21:23 +0200 |
commit | 6afad7276402a90b3776ddeefb205978af42fdab (patch) | |
tree | 595886e869c364e504eacc1d472c07ae51d7bb4a /ax25/axgetput | |
parent | ca4de17280673efe76a95bf904d11e1fa75c62d4 (diff) |
Delete more assignments in if conditions.
Based on below coccinelle script with a bad transformation fixed up
manually.
@if1@
expression E, F, G;
binary operator X;
statement S;
@@
- if ((E = F) X G)
+ E = F;
+ if (E X G)
S
@if2@
expression E, F, G;
binary operator X;
statement S;
@@
- if (G X (E = F))
+ E = F;
+ if (E X G)
S
@if3@
expression E, F;
statement S;
@@
- if (!(E = F))
+ E = F;
+ if (!E)
S
@if4@
expression E, F;
statement S;
@@
- if ((E = F))
+ E = F;
+ if (E)
S
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'ax25/axgetput')
-rw-r--r-- | ax25/axgetput/proto_bin.c | 3 | ||||
-rw-r--r-- | ax25/axgetput/util.c | 15 |
2 files changed, 12 insertions, 6 deletions
diff --git a/ax25/axgetput/proto_bin.c b/ax25/axgetput/proto_bin.c index 69d12a4..7d5eb3a 100644 --- a/ax25/axgetput/proto_bin.c +++ b/ax25/axgetput/proto_bin.c @@ -484,7 +484,8 @@ int bget(void) { } if (fdin_is_pipe && !is_stream) { sl = stored_file; - if (!(stored_file = stored_file->next)) + stored_file = stored_file->next; + if (!stored_file) is_eof = 1; free(sl); } diff --git a/ax25/axgetput/util.c b/ax25/axgetput/util.c index a4a83c0..69adb60 100644 --- a/ax25/axgetput/util.c +++ b/ax25/axgetput/util.c @@ -116,19 +116,23 @@ char *get_fixed_filename(char *line, long size, unsigned int msg_crc, int genera *filename = 0; - if ((p = strchr(line, '\"'))) { + p = strchr(line, '\"'); + if (p) { p++; } /* security.. */ - if ((q = strrchr((p ? p : line), '/'))) { + q = strrchr((p ? p : line), '/'); + if (q) { p = ++q; } - if ((q = strrchr((p ? p : line), '\\'))) { + q = strrchr((p ? p : line), '\\'); + if (q) { p = ++q; } - if ((q = strrchr((p ? p : line), ':'))) { + q = strrchr((p ? p : line), ':'); + if (q) { p = ++q; } if (!p) { @@ -144,7 +148,8 @@ char *get_fixed_filename(char *line, long size, unsigned int msg_crc, int genera } *r = 0; strtrim(filename); - if ((q = strrchr(filename, '.'))) { + q = strrchr(filename, '.'); + if (q) { if (!*(q+1)) { /* remove trailing dots */ *q = 0; |