| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
| |
While add it force the distribution of README and TODO in the same
directory instead of relying on automake's default behaviour.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
There is no axparms(5) man page but axports(5) would make sense.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Based on below coccinelle script with a bad transformation fixed up
manually.
@if1@
expression E, F, G;
binary operator X;
statement S;
@@
- if ((E = F) X G)
+ E = F;
+ if (E X G)
S
@if2@
expression E, F, G;
binary operator X;
statement S;
@@
- if (G X (E = F))
+ E = F;
+ if (E X G)
S
@if3@
expression E, F;
statement S;
@@
- if (!(E = F))
+ E = F;
+ if (!E)
S
@if4@
expression E, F;
statement S;
@@
- if ((E = F))
+ E = F;
+ if (E)
S
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is using the following semantic patch:
@identitycast@
type T;
T *A;
@@
- (T *) A
+ A
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is using the following semantic patch:
@memset@
type T;
expression A, B, C;
@@
- memset((T *)A, B, C)
+ memset(A, B, C)
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Somewhat hard to read and the code base already has many overlong
lines.
Found with below spatch file and some manual editing in ax25/access.c
to restore a comment lost by spatch.
@parens@
expression E, F, G;
binary operator X;
statement S;
@@
- if ((E = F) X G)
+ E = F;
+ if (E X G)
S
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
In particular this remove reliance on how file descriptors are assigned
and ensures we don't pass an unnecessarily high nfds argument to select.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -g -O2 -Wall -o axspawn axspawn.o access.o md5.o -lax25 -lutil
gcc -DHAVE_CONFIG_H -I. -I.. -D_GNU_SOURCE -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/us
r/local/var/ax25/"\" -g -O2 -Wall -MT axwrapper.o -MD -MP -MF .deps/axwrapper.Tpo -c -o axwrapper.o axwrapper.c
axwrapper.c:49:13: warning: ‘sigchld_handler’ defined but not used [-Wunused-function]
static void sigchld_handler(int sig)
^~~~~~~~~~~~~~~
Since 71918b7d4e95 ("axwrapper: Mark functions sigchld_handler and
convert_{cr_lf,lf_cr} static.") made sigchld_handler() static gcc was
warning about the function being unused. No point in keeping this around;
SIGCHLD is perfectly fine.
Fixes: 71918b7d4e95 ("axwrapper: Mark functions sigchld_handler and convert_{cr_lf,lf_cr} static.")
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
No files were listed in the FILES section.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
malloc returns a void pointer so no cast is necessary when
assigning to a pointer type.
Found with below coccinelle script:
@malloccast@
type T;
@@
- (T *)
malloc(...)
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
| |
For one strlen does not return any errors. By its very nature strlen
does not return negative results and its return type is size_t which
happens to be unsigned.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -D_GNU_SOURCE -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -Wall -Wextra -MT mheard.o -MD -MP -MF .deps/mheard.Tpo -c -o mheard.o mheard.c
[...]
mheard.c:135:22: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (pr->entry.type < 0 || pr->entry.type > sizeof(types))
^
mheard.c:168:22: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (pr->entry.type < 0 || pr->entry.type > sizeof(types))
^
[...]
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
And add proper declarations to the header file.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
| |
And then delete those now useless declarations.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
| |
This results in a new warning about sigchld_handler() being unused which
is because the caller is currently commented out which we leave to be
sorted out later.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -D_GNU_SOURCE -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -Wall -pedantic -MT axspawn.o -MD -MP -MF .deps/axspawn.Tpo -c -o axspawn.o axspawn.c
axspawn.c: In function ‘encstathuf’:
axspawn.c:555:15: warning: overflow in implicit constant conversion [-Woverflow]
dest[0] = 255;
^~~
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
__USE_XOPEN doesn't work to get ptsname() etc. from libc. This is
Linux-specific software so convert to _GNU_SOURCE.
make[2]: Entering directory '/home/ralf/src/ax25/ax25-tools/kiss'
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O
2 -Wall -pedantic -MT kissattach.o -MD -MP -MF .deps/kissattach.Tpo -c -o kissattach.o kissattach.c
kissattach.c: In function ‘main’:
kissattach.c:312:18: warning: implicit declaration of function ‘ptsname’ [-Wimplicit-function-declaration]
if ((namepts = ptsname(fd)) == NULL) {
^~~~~~~
kissattach.c:312:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((namepts = ptsname(fd)) == NULL) {
^
kissattach.c:317:7: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
if (unlockpt(fd) == -1) {
^~~~~~~~
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -Wall -pedantic -MT kissnetd.o -MD -MP -MF .deps/kissnetd.Tpo -c -o kissnetd.o kissnetd.c
kissnetd.c: In function ‘ReopenPort’:
kissnetd.c:134:16: warning: implicit declaration of function ‘ptsname’ [-Wimplicit-function-declaration]
if ((npts = ptsname(PortList[PortNumber]->Fd)) == NULL) {
^~~~~~~
kissnetd.c:134:14: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((npts = ptsname(PortList[PortNumber]->Fd)) == NULL) {
^
kissnetd.c:143:8: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
if (unlockpt(PortList[PortNumber]->Fd) == -1) {
^~~~~~~~
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -Wall -pedantic -MT mkiss.o -MD -MP -MF .deps/mkiss.Tpo -c -o mkiss.o mkiss.c
mkiss.c: In function ‘poll’:
mkiss.c:68:15: warning: overflow in implicit constant conversion [-Woverflow]
#define FEND 0300 /* Frame End (0xC0) */
^
mkiss.c:149:14: note: in expansion of macro ‘FEND’
buffer[0] = FEND;
^~~~
mkiss.c:68:15: warning: overflow in implicit constant conversion [-Woverflow]
#define FEND 0300 /* Frame End (0xC0) */
^
mkiss.c:151:14: note: in expansion of macro ‘FEND’
buffer[2] = FEND;
^~~~
mkiss.c: In function ‘main’:
mkiss.c:568:16: warning: implicit declaration of function ‘ptsname’ [-Wimplicit-function-declaration]
if ((npts = ptsname(pty[i]->fd)) == NULL) {
^~~~~~~
mkiss.c:568:14: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((npts = ptsname(pty[i]->fd)) == NULL) {
^
mkiss.c:578:8: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
if (unlockpt(pty[i]->fd) == -1) {
^~~~~~~~
mkiss.c:672:33: warning: ISO C does not support the ‘%m’ gnu_printf format [-Wformat=]
syslog(LOG_ERR, "tty->fd: %m");
^
mkiss.c:698:38: warning: ISO C does not support the ‘%m’ gnu_printf format [-Wformat=]
syslog(LOG_ERR, "pty[%d]->fd: %m\n", i);
[...] ^
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -Wall -pedantic -MT net2kiss.o -MD -MP -MF .deps/net2kiss.Tpo -c -o net2kiss.o net2kiss.c
net2kiss.c: In function ‘main’:
net2kiss.c:630:18: warning: implicit declaration of function ‘ptsname’ [-Wimplicit-function-declaration]
if ((namepts = ptsname(fdpty)) == NULL) {
^~~~~~~
net2kiss.c:630:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((namepts = ptsname(fdpty)) == NULL) {
^
net2kiss.c:635:7: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
if (unlockpt(fdpty) == -1) {
^~~~~~~~
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -Wall -pedantic -MT m6pack.o -MD -MP -MF .deps/m6pack.Tpo -c -o m6pack.o m6pack.c
m6pack.c: In function ‘main’:
m6pack.c:537:16: warning: implicit declaration of function ‘ptsname’ [-Wimplicit-function-declaration]
if ((npts = ptsname(pty[i]->fd)) == NULL) {
^~~~~~~
m6pack.c:537:14: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((npts = ptsname(pty[i]->fd)) == NULL) {
^
m6pack.c:545:8: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
if (unlockpt(pty[i]->fd) == -1) {
^~~~~~~~
m6pack.c:626:33: warning: ISO C does not support the ‘%m’ gnu_printf format [-Wformat=]
syslog(LOG_ERR, "tty->fd: %m");
^
m6pack.c:658:29: warning: ISO C does not support the ‘%m’ gnu_printf format [-Wformat=]
"pty[%d]->fd: %m\n",i);
^
[...]
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
beacon.c: In function ‘main’:
beacon.c:146:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if (addr != NULL) free(addr); addr = NULL;
^~
beacon.c:146:32: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
if (addr != NULL) free(addr); addr = NULL;
^~~~
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
beacon.c: In function ‘main’:
beacon.c:128:2: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if (addr != NULL) free(addr); addr = NULL;
^~
beacon.c:128:32: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
if (addr != NULL) free(addr); addr = NULL;
^~~~
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
| |
axspawn.c:1777:4: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
if (pw->pw_dir && *(pw->pw_dir))
^~
axspawn.c:1779:5: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘if’
ret = chdir(p);
^~~
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
This uses a setlocalversion script derived from the kernel's
scripts/setlocalversion.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
As far as I can track this back in history /proc/net/ax25_bpqether has
never been correct.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
|
|
|
|
|
|
| |
Has nicer time representation, too.
Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
port record data can be garbled. We cannot trust the data.
i.e., ctime() returns NULL at time_t 2^33 (72057594037927936).
char lh[] was size 30. This is not enough for year > 999999999.
also assure that pr->entry.type is < sizeof(types), and in 'case 4:',
only up to 8 digipeaters are copied.
Thanks to Guido Trentalancia <iz6rdb@trentalancia.net> for the patch.
Also changed printf to %u (because mheard's struct has unsigned int values)
and enhanced formating (%8 instead of %5).
Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
|
|
|
|
|
|
| |
Idea by Folkert van Heusden <mail@vanheusden.com>.
Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
|
|
|
|
|
|
| |
patch submitted by Folkert van Heusden <mail@vanheusden.com>.
Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
|