| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT mheardd.o -MD -MP -MF .deps/mheardd.Tpo -c -o mheardd.o mheardd.c
mheardd.c: In function ‘main’:
mheardd.c:259:22: warning: pointer targets in passing argument 1 of ‘ax25_validate’ differ in signedness [-Wpointer-sign]
if (!ax25_validate(data + 0) || !ax25_validate(data + AXLEN)) {
^
In file included from mheardd.c:31:0:
/usr/include/netax25/axlib.h:116:12: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
extern int ax25_validate(const char *);
^
mheardd.c:259:50: warning: pointer targets in passing argument 1 of ‘ax25_validate’ differ in signedness [-Wpointer-sign]
if (!ax25_validate(data + 0) || !ax25_validate(data + AXLEN)) {
^
In file included from mheardd.c:31:0:
/usr/include/netax25/axlib.h:116:12: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
extern int ax25_validate(const char *);
^
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT axwrapper.o -MD -MP -MF .deps/axwrapper.Tpo -c -o axwrapper.o axwrapper.c
axwrapper.c: In function ‘main’:
axwrapper.c:105:17: warning: pointer targets in passing argument 2 of ‘setvbuf’ differ in signedness [-Wpointer-sign]
setvbuf(stdout, stdoutbuf, _IOFBF, paclen);
^
In file included from axwrapper.c:36:0:
/usr/include/stdio.h:336:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern int setvbuf (FILE *__restrict __stream, char *__restrict __buf,
^
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT axspawn.o -MD -MP -MF .deps/axspawn.Tpo -c -o axspawn.o axspawn.c
axspawn.c: In function ‘decstathuf’:
axspawn.c:595:9: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
srcptr = src;
^
axspawn.c:596:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
destptr = dest;
^
axspawn.c: In function ‘read_ax25’:
axspawn.c:675:19: warning: pointer targets in passing argument 1 of ‘decstathuf’ differ in signedness [-Wpointer-sign]
if (!decstathuf(s, decomp, len, &declen)) {
^
axspawn.c:584:5: note: expected ‘char *’ but argument is of type ‘unsigned char *’
int decstathuf(char *src, char *dest, int srclen, int *destlen)
^
axspawn.c:677:11: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(s, decomp);
^
In file included from axspawn.c:149:0:
/usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
axspawn.c:690:31: warning: pointer targets in passing argument 1 of ‘Strncasecmp’ differ in signedness [-Wpointer-sign]
if (!huffman && !Strncasecmp(s, "//COMP ON\n", 10)) {
^
axspawn.c:498:5: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
int Strncasecmp(const char *s1, const char *s2, int n)
^
axspawn.c:704:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(s,"\n");
^
In file included from axspawn.c:149:0:
/usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
axspawn.c:708:30: warning: pointer targets in passing argument 1 of ‘Strncasecmp’ differ in signedness [-Wpointer-sign]
if (huffman && !Strncasecmp(s, "//COMP OFF\n", 11)) {
^
axspawn.c:498:5: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
int Strncasecmp(const char *s1, const char *s2, int n)
^
axspawn.c:727:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(s,"\n");
^
In file included from axspawn.c:149:0:
/usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
axspawn.c: In function ‘new_user’:
axspawn.c:1101:5: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
q = strchr(p, '/');
^
axspawn.c:1145:5: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
p = q;
^
axspawn.c: In function ‘main’:
axspawn.c:1557:17: warning: pointer targets in passing argument 1 of ‘read_ax25’ differ in signedness [-Wpointer-sign]
if (read_ax25(buf, sizeof(buf)) < 0)
^
axspawn.c:662:5: note: expected ‘unsigned char *’ but argument is of type ‘char *’
int read_ax25(unsigned char *s, int size)
^
axspawn.c:1571:24: warning: pointer targets in passing argument 1 of ‘read_ax25’ differ in signedness [-Wpointer-sign]
if ((cnt = read_ax25(buf, sizeof(buf)-1)) < 0)
^
axspawn.c:662:5: note: expected ‘unsigned char *’ but argument is of type ‘char *’
int read_ax25(unsigned char *s, int size)
^
axspawn.c:1655:19: warning: pointer targets in passing argument 1 of ‘read_ax25’ differ in signedness [-Wpointer-sign]
cnt = read_ax25(buf, sizeof(buf)-1);
^
axspawn.c:662:5: note: expected ‘unsigned char *’ but argument is of type ‘char *’
int read_ax25(unsigned char *s, int size)
^
axspawn.c:1930:22: warning: pointer targets in passing argument 1 of ‘read_ax25’ differ in signedness [-Wpointer-sign]
cnt = read_ax25(buf, sizeof(buf));
^
axspawn.c:662:5: note: expected ‘unsigned char *’ but argument is of type ‘char *’
int read_ax25(unsigned char *s, int size)
^
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT access.o -MD -MP -MF .deps/access.Tpo -c -o access.o access.c
access.c: In function ‘calc_md5_pw’:
access.c:194:23: warning: pointer targets in passing argument 2 of ‘MD5Update’ differ in signedness [-Wpointer-sign]
MD5Update(&context, buffer+i, n);
^
In file included from access.c:13:0:
md5.h:60:6: note: expected ‘unsigned char *’ but argument is of type ‘char *’
void MD5Update(MD5_CTX *mdContext, unsigned char *inBuf, unsigned int inLen);
^
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
| |
1905bd6c7e1123adccfd24803fea67227228d38c (Substitute proper paths in
ax25d.conf.) accidently dropped the filename, that is node, from the
path of the node binary.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
| |
Since 1905bd6c7e1123adccfd24803fea67227228d38c (Substitute proper paths
in ax25d.conf.) ax25/ax25d.conf is a generated file and should have
been deleted.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depending on the prefix configured, the default ax25d.conf file may
contain incorrects paths. Generate config file using the correct
sbin dir.
Assume node which is not part of ax25-tools to be installed with the
same prefix. Don't probe - chances are the sysadmin of a node system
is going to install it after ax25-tools so we'd likely have to guess
which never is a good thing.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Axwrapper first creates a pipe and then forks and execs the program
<server-program> with arguments given at the axwrapper command line.
The argv[0] argument is mandatory; further arguments are optional. The
parent process then sits and waits for any I/O to and from the user and
converts any carriage return characters from the user to line feeds and
any line feeds from the program to carriage returns.
This is useful when starting non-AX.25-aware programs from ax25d.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -MT axparms.o -MD -MP -MF .deps/axparms.Tpo -c -o axparms.o axparms.c
axparms.c: In function ‘routes’:
axparms.c:142:4: error: format not a string literal and no format arguments [-Werror=format-security]
printf(routebuf);
^
axparms.c: In function ‘associate’:
axparms.c:189:3: warning: ignoring return value of ‘fgets’, declared with attribute warn_unused_result [-Wunused-result]
fgets(buffer, 80, fp);
^
cc1: some warnings being treated as errors
Makefile:570: recipe for target 'axparms.o' failed
make[3]: *** [axparms.o] Error 1
Note that routebuf has been read from /procfs so should be safe.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the automake warnings:
6pack/Makefile.am:10: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
Makefile.am:9: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
ax25/Makefile.am:26: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
hdlcutil/Makefile.am:16: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
kiss/Makefile.am:11: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
netrom/Makefile.am:28: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
rose/Makefile.am:15: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
tcpip/Makefile.am:27: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
INCLUDES has been deprecated since automake 1.5.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25
_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT axspawn.o -MD -MP
-MF .deps/axspawn.Tpo -c -o axspawn.o axspawn.c
[...]
axspawn.c:1049:7: warning: unused variable ‘command’ [-Wunused-variable]
char command[1024];
^
[...]
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|\
| |
| |
| |
| | |
Conflicts:
ax25/axspawn.c
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| |
| |
| |
| | |
Indentation by tabs only. Move case labels in switches are on the same
level as the switch keyword.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| |
| |
| |
| | |
They only inflate the .data section of the binary. Initializations to
FALSE are still left to do.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
| |
| |
| | |
Signed-off-by: Thomas Osterried <thomas@osterried.de>
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Security patch submitted by Jaroslav Skarvada <jskarvad@redhat.com>
Netrom and ROSE Addresses are copied to Node.
Room was enough for Netrom, but rose addresses returned by rose_ntoa()
are one byte longer (a 10 bytes string plus null-termination) which lead
to an buffer overflow.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The user_shell config variable is optional. If not specified, /bin/bash is
used. Except: if create_with_useradd is configured and there's a config
file /etc/default/useradd, then it's not passed to useradd in order to let
the user choose.
Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cpu power, if it was called from axspawn. This could be prevented if
SIGCHLD is masked.
To increase security, no longer call useradd via system() but fork() and
execve().
Fixed a bug when useradd failed then the login process continued anyway.
Empty lines in axspawn.conf are now valid.
The user_shell config variable is optional. If not specified, /bin/bash is
used. Except: if create_with_useradd is configured and there's a config
file /etc/default/useradd, then it's not passed to useradd in order to let
him choose.
Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
|
|
|
|
|
|
|
| |
Their value has always been dubious and git doesn't support them so let's
get rid of the clutter.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
| |
process group leader, setsid() fails.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
| |
login -f -h <protocol> <as_user>
did not work.
login -h <protocol> -f <as_user>
did work. Imho, OpenSUSE meessed up login's getopt()...
On the other hand, we have no problems to switch the position
of arguments - as long as there's not another linux demanding
another position ;)
|
|
|
|
|
|
|
|
| |
install-exec-local hooks may be run in parallel. This may result in
the attempted installation of files into directories before they have
been created. Fixed by using install-exec-hook instead.
Reported and axgetput-only patch by Thomas Beierlein <tb@forth-ev.de>.
|
|
|
|
|
| |
In a world that is caught between ISO 8859-1, ISO 8859-15 and UTF-8
non-ASCII characters are a guaranteed mess, still.
|
|
|
|
| |
These should be declared by unistd.h only.
|
|
|
|
| |
<errno.h> is the way to go.
|
|
|
|
|
|
| |
Glibc as old as 2.2 provides working headers under the right name and
if not libax25 would install headers under the right name so this has
become redundant and ugly.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keeping generated files in CVS doesn't only tend to produce large and
cluttered files it also may result in build problems due to timestamps
in the wrong order. So dump everything, update .cvsignore to ignore
these files and resolve all warnings generated by autoreconf.
From now on users of a CVS checkout should run the command
autoreconf --install --force
after having done a CVS checkout. For this to succeed automake, autoconf
and libtool will have to be installed.
|
|
|
|
|
|
|
|
| |
Various socket syscalls receive a length argument that should be a
socklen_t rsp. a ptr to a socklen_t but instead int rsp. ptr to int were
being passed. While in theory this was a bug it's harmless as dangerously
large values would not be used but the issue manifested itself in a
significant number of compilation warnings.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks to using the antiquated time(2) call the microsecond field of the
struct utmp being manipulated was never initialized resulting in random
values. On some 64-bit systems this also manifested itself in below
warnings.
axspawn.c: In function ‘cleanup’:
axspawn.c:1017: warning: passing argument 1 of ‘time’ from incompatible pointer type
/usr/include/time.h:186: note: expected ‘time_t *’ but argument is of type ‘int32_t *’
[...]
axspawn.c: In function ‘main’:
[...]
axspawn.c:1693: warning: passing argument 1 of ‘time’ from incompatible pointer type
/usr/include/time.h:186: note: expected ‘time_t *’ but argument is of type ‘int32_t *’
Fixed by changing it to the recommended initialization sequenze based on
gettimeofday().
|
| |
|
| |
|
| |
|