| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
|
|
|
|
| |
In some of these pages the content was changed relativly recently but
the date in the man page itself was never updated so dates were off by
decades. Update all man pages to last non-trival change recorded in
git since imported.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Arguably useful in documenting the return value is intentionally ignored
I think it's just cluttering the screen.
This is using the following semantic patch:
@castvoid@
expression F;
@@
- (void) F
+ F
(...)
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Somewhat hard to read and the code base already has many overlong
lines.
Found with below spatch file and some manual editing in ax25/access.c
to restore a comment lost by spatch.
@parens@
expression E, F, G;
binary operator X;
statement S;
@@
- if ((E = F) X G)
+ E = F;
+ if (E X G)
S
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -D_GNU_SOURCE -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/va
r/ax25/"\" -O2 -Wall -pedantic -MT netromt.o -MD -MP -MF .deps/netromt.Tpo -c -o netromt.o netromt.c
In file included from netromt.c:24:0:
netromt.c: In function ‘build_header’:
netromd.h:10:19: warning: overflow in implicit constant conversion [-Woverflow]
#define NODES_SIG 0xFF
^
netromt.c:28:15: note: in expansion of macro ‘NODES_SIG’
message[0] = NODES_SIG;
^~~~~~~~~
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
__USE_XOPEN doesn't work to get ptsname() etc. from libc. This is
Linux-specific software so convert to _GNU_SOURCE.
make[2]: Entering directory '/home/ralf/src/ax25/ax25-tools/kiss'
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O
2 -Wall -pedantic -MT kissattach.o -MD -MP -MF .deps/kissattach.Tpo -c -o kissattach.o kissattach.c
kissattach.c: In function ‘main’:
kissattach.c:312:18: warning: implicit declaration of function ‘ptsname’ [-Wimplicit-function-declaration]
if ((namepts = ptsname(fd)) == NULL) {
^~~~~~~
kissattach.c:312:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((namepts = ptsname(fd)) == NULL) {
^
kissattach.c:317:7: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
if (unlockpt(fd) == -1) {
^~~~~~~~
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -Wall -pedantic -MT kissnetd.o -MD -MP -MF .deps/kissnetd.Tpo -c -o kissnetd.o kissnetd.c
kissnetd.c: In function ‘ReopenPort’:
kissnetd.c:134:16: warning: implicit declaration of function ‘ptsname’ [-Wimplicit-function-declaration]
if ((npts = ptsname(PortList[PortNumber]->Fd)) == NULL) {
^~~~~~~
kissnetd.c:134:14: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((npts = ptsname(PortList[PortNumber]->Fd)) == NULL) {
^
kissnetd.c:143:8: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
if (unlockpt(PortList[PortNumber]->Fd) == -1) {
^~~~~~~~
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -Wall -pedantic -MT mkiss.o -MD -MP -MF .deps/mkiss.Tpo -c -o mkiss.o mkiss.c
mkiss.c: In function ‘poll’:
mkiss.c:68:15: warning: overflow in implicit constant conversion [-Woverflow]
#define FEND 0300 /* Frame End (0xC0) */
^
mkiss.c:149:14: note: in expansion of macro ‘FEND’
buffer[0] = FEND;
^~~~
mkiss.c:68:15: warning: overflow in implicit constant conversion [-Woverflow]
#define FEND 0300 /* Frame End (0xC0) */
^
mkiss.c:151:14: note: in expansion of macro ‘FEND’
buffer[2] = FEND;
^~~~
mkiss.c: In function ‘main’:
mkiss.c:568:16: warning: implicit declaration of function ‘ptsname’ [-Wimplicit-function-declaration]
if ((npts = ptsname(pty[i]->fd)) == NULL) {
^~~~~~~
mkiss.c:568:14: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((npts = ptsname(pty[i]->fd)) == NULL) {
^
mkiss.c:578:8: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
if (unlockpt(pty[i]->fd) == -1) {
^~~~~~~~
mkiss.c:672:33: warning: ISO C does not support the ‘%m’ gnu_printf format [-Wformat=]
syslog(LOG_ERR, "tty->fd: %m");
^
mkiss.c:698:38: warning: ISO C does not support the ‘%m’ gnu_printf format [-Wformat=]
syslog(LOG_ERR, "pty[%d]->fd: %m\n", i);
[...] ^
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -Wall -pedantic -MT net2kiss.o -MD -MP -MF .deps/net2kiss.Tpo -c -o net2kiss.o net2kiss.c
net2kiss.c: In function ‘main’:
net2kiss.c:630:18: warning: implicit declaration of function ‘ptsname’ [-Wimplicit-function-declaration]
if ((namepts = ptsname(fdpty)) == NULL) {
^~~~~~~
net2kiss.c:630:16: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((namepts = ptsname(fdpty)) == NULL) {
^
net2kiss.c:635:7: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
if (unlockpt(fdpty) == -1) {
^~~~~~~~
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -Wall -pedantic -MT m6pack.o -MD -MP -MF .deps/m6pack.Tpo -c -o m6pack.o m6pack.c
m6pack.c: In function ‘main’:
m6pack.c:537:16: warning: implicit declaration of function ‘ptsname’ [-Wimplicit-function-declaration]
if ((npts = ptsname(pty[i]->fd)) == NULL) {
^~~~~~~
m6pack.c:537:14: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
if ((npts = ptsname(pty[i]->fd)) == NULL) {
^
m6pack.c:545:8: warning: implicit declaration of function ‘unlockpt’ [-Wimplicit-function-declaration]
if (unlockpt(pty[i]->fd) == -1) {
^~~~~~~~
m6pack.c:626:33: warning: ISO C does not support the ‘%m’ gnu_printf format [-Wformat=]
syslog(LOG_ERR, "tty->fd: %m");
^
m6pack.c:658:29: warning: ISO C does not support the ‘%m’ gnu_printf format [-Wformat=]
"pty[%d]->fd: %m\n",i);
^
[...]
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
| |
This uses a setlocalversion script derived from the kernel's
scripts/setlocalversion.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT netromr.o -MD -MP -MF .deps/netromr.Tpo -c -o netromr.o netromr.c
netromr.c: In function ‘receive_nodes’:
netromr.c:143:8: warning: variable ‘addr’ set but not used [-Wunused-but-set-variable]
char *addr, *callsign, *device;
^
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT netromt.o -MD -MP -MF .deps/netromt.Tpo -c -o netromt.o netromt.c
netromt.c: In function ‘build_others’:
netromt.c:102:13: warning: variable ‘number’ set but not used [-Wunused-but-set-variable]
int which, number, quality, neigh_no, obs_count;
^
netromt.c:102:6: warning: variable ‘which’ set but not used [-Wunused-but-set-variable]
int which, number, quality, neigh_no, obs_count;
^
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT nrsdrv.o -MD -MP -MF .deps/nrsdrv.Tpo -c -o nrsdrv.o nrsdrv.c
nrsdrv.c: In function ‘main’:
nrsdrv.c:438:15: warning: pointer targets in passing argument 1 of ‘kiss_unesc’ differ in signedness [-Wpointer-sign]
kiss_unesc(buffer, n);
^
nrsdrv.c:246:13: note: expected ‘unsigned char *’ but argument is of type ‘char *’
static void kiss_unesc(unsigned char *buffer, int len)
^
nrsdrv.c:449:14: warning: pointer targets in passing argument 1 of ‘nrs_unesc’ differ in signedness [-Wpointer-sign]
nrs_unesc(buffer, n);
^
nrsdrv.c:192:13: note: expected ‘unsigned char *’ but argument is of type ‘char *’
static void nrs_unesc(unsigned char *buffer, int len)
^
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT netromt.o -MD -MP -MF .deps/netromt.Tpo -c -o netromt.o netromt.c
netromt.c: In function ‘build_header’:
netromt.c:30:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(message + 1, nr_config_get_alias(NULL));
^
In file included from netromt.c:4:0:
/usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
netromt.c:31:12: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]
strncat(message + 1, " ", MNEMONIC_LEN - strlen(message + 1));
^
In file included from netromt.c:4:0:
/usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
extern size_t strlen (const char *__s)
^
netromt.c:31:1: warning: pointer targets in passing argument 1 of ‘__builtin_strncat’ differ in signedness [-Wpointer-sign]
strncat(message + 1, " ", MNEMONIC_LEN - strlen(message + 1));
^
netromt.c:31:1: note: expected ‘char *’ but argument is of type ‘unsigned char *’
netromt.c: In function ‘build_mine’:
netromt.c:66:49: warning: pointer targets in passing argument 2 of ‘ax25_aton_entry’ differ in signedness [-Wpointer-sign]
if (ax25_aton_entry(nr_config_get_addr(port), message + len) == -1) {
^
In file included from netromt.c:19:0:
/usr/include/netax25/axlib.h:58:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’
extern int ax25_aton_entry(const char *, char *);
^
netromt.c:74:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(message + len, nr_config_get_alias(port));
^
In file included from netromt.c:4:0:
/usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
netromt.c:75:13: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]
strncat(message + len, " ", MNEMONIC_LEN - strlen(message + len));
^
In file included from netromt.c:4:0:
/usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
extern size_t strlen (const char *__s)
^
netromt.c:75:2: warning: pointer targets in passing argument 1 of ‘__builtin_strncat’ differ in signedness [-Wpointer-sign]
strncat(message + len, " ", MNEMONIC_LEN - strlen(message + len));
^
netromt.c:75:2: note: expected ‘char *’ but argument is of type ‘unsigned char *’
netromt.c:78:44: warning: pointer targets in passing argument 2 of ‘ax25_aton_entry’ differ in signedness [-Wpointer-sign]
ax25_aton_entry(nr_config_get_addr(NULL), message + len);
^
In file included from netromt.c:19:0:
/usr/include/netax25/axlib.h:58:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’
extern int ax25_aton_entry(const char *, char *);
^
netromt.c: In function ‘build_others’:
netromt.c:156:34: warning: pointer targets in passing argument 2 of ‘ax25_aton_entry’ differ in signedness [-Wpointer-sign]
if (ax25_aton_entry(callsign, message + len) == -1) {
^
In file included from netromt.c:19:0:
/usr/include/netax25/axlib.h:58:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’
extern int ax25_aton_entry(const char *, char *);
^
netromt.c:163:11: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(message + len, mnemonic);
^
In file included from netromt.c:4:0:
/usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
netromt.c:164:14: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]
strncat(message + len, " ", MNEMONIC_LEN - strlen(message + len));
^
In file included from netromt.c:4:0:
/usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
extern size_t strlen (const char *__s)
^
netromt.c:164:3: warning: pointer targets in passing argument 1 of ‘__builtin_strncat’ differ in signedness [-Wpointer-sign]
strncat(message + len, " ", MNEMONIC_LEN - strlen(message + len));
^
netromt.c:164:3: note: expected ‘char *’ but argument is of type ‘unsigned char *’
netromt.c:167:35: warning: pointer targets in passing argument 2 of ‘ax25_aton_entry’ differ in signedness [-Wpointer-sign]
if (ax25_aton_entry(neighbour, message + len) == -1) {
^
In file included from netromt.c:19:0:
/usr/include/netax25/axlib.h:58:12: note: expected ‘char *’ but argument is of type ‘unsigned char *’
extern int ax25_aton_entry(const char *, char *);
^
[...]
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
make[2]: Entering directory '/home/ralf/src/ax25/ax25-tools/netrom'
gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -MT nrparms.o -MD -MP -MF .deps/nrparms.Tpo -c -o nrparms.o nrparms.c
nrparms.c: In function ‘main’:
nrparms.c:213:4: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf(stderr, nodes_usage);
^
nrparms.c:224:4: error: format not a string literal and no format arguments [-Werror=format-security]
fprintf(stderr, routes_usage);
^
cc1: some warnings being treated as errors
Makefile:438: recipe for target 'nrparms.o' failed
make[2]: *** [nrparms.o] Error 1
make[2]: Leaving directory '/home/ralf/src/ax25/ax25-tools/netrom'
The strings are constants in the application code itself so no security
issue.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the automake warnings:
6pack/Makefile.am:10: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
Makefile.am:9: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
ax25/Makefile.am:26: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
hdlcutil/Makefile.am:16: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
kiss/Makefile.am:11: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
netrom/Makefile.am:28: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
rose/Makefile.am:15: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
tcpip/Makefile.am:27: warning: 'INCLUDES' is the old name for 'AM_CPPFLAGS' (or '*_CPPFLAGS')
INCLUDES has been deprecated since automake 1.5.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |\
| |
| |
| |
| | |
Conflicts:
ax25/axspawn.c
|
| | |
| |
| |
| |
| |
| |
| | |
Indentation by tabs only. Move case labels in switches are on the same
level as the switch keyword.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| | |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| | |
| |
| |
| |
| |
| |
| | |
They only inflate the .data section of the binary. Initializations to
FALSE are still left to do.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| | |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| | |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| | |
| |
| |
| | |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| | |
| |
| |
| |
| |
| | |
and rose devices (previously 4 netrom, 6 rose).
Thanks to Jaroslav, OK2JRQ for the patch
|
| |/
|
|
|
|
|
|
| |
First compute the node quality by remotely reported quality * best_quality)
+ 128) / 256; (the well known algorithm) and afterwards verify if it's
< worst_qual.
Signed-off-by: Thomas Osterried <thomas@osterried.de>
|
| |
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
| |
This utility apparently was removed for ax25-utils 2.1.37 released
in May 1997.
|
| |
|
|
| |
Thanks to Bernard <f6bvp> for reporting this problem.
|
| |
|
|
|
|
| |
Glibc as old as 2.2 provides working headers under the right name and
if not libax25 would install headers under the right name so this has
become redundant and ugly.
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keeping generated files in CVS doesn't only tend to produce large and
cluttered files it also may result in build problems due to timestamps
in the wrong order. So dump everything, update .cvsignore to ignore
these files and resolve all warnings generated by autoreconf.
From now on users of a CVS checkout should run the command
autoreconf --install --force
after having done a CVS checkout. For this to succeed automake, autoconf
and libtool will have to be installed.
|
| |
|
|
|
|
|
|
| |
Various socket syscalls receive a length argument that should be a
socklen_t rsp. a ptr to a socklen_t but instead int rsp. ptr to int were
being passed. While in theory this was a bug it's harmless as dangerously
large values would not be used but the issue manifested itself in a
significant number of compilation warnings.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
