summaryrefslogtreecommitdiffstats
path: root/rose/rsuplnk.c
Commit message (Collapse)AuthorAgeFilesLines
* treewide: Kill assignments in if conditions.Ralf Baechle2017-07-311-5/+10
| | | | | | | | | | | | | | | | | | | | Somewhat hard to read and the code base already has many overlong lines. Found with below spatch file and some manual editing in ax25/access.c to restore a comment lost by spatch. @parens@ expression E, F, G; binary operator X; statement S; @@ - if ((E = F) X G) + E = F; + if (E X G) S Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* rsuplnk: Add cast to silence useless warning.Ralf Baechle2017-02-061-1/+1
| | | | | | | | | rsuplnk.c: In function ‘main’: rsuplnk.c:262:17: warning: overflow in implicit constant conversion [-Woverflow] buffer[0] = 0xF0; ^~~~ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* rsuplnk: Make function alarm_handler static.Ralf Baechle2017-02-061-1/+1
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* rose/rsuplnk.c: Fix signedness compiler warnings.Ralf Baechle2015-06-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT rsuplnk.o -MD -MP -MF .deps/rsuplnk.Tpo -c -o rsuplnk.o rsuplnk.c rsuplnk.c: In function ‘main’: rsuplnk.c:85:12: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] if ((addr = rs_config_get_addr(argv[1])) == NULL) { ^ rsuplnk.c:91:16: warning: pointer targets in passing argument 1 of ‘rose_aton’ differ in signedness [-Wpointer-sign] if (rose_aton(addr, rosebind.srose_addr.rose_addr) == -1) { ^ In file included from rsuplnk.c:17:0: /usr/include/netax25/axlib.h:84:12: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern int rose_aton(const char *, char *); ^ rsuplnk.c:104:8: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] addr = ax25_ntoa(&ax25peer.fsa_digipeater[n]); ^ rsuplnk.c:106:6: warning: pointer targets in passing argument 1 of ‘__builtin_strspn’ differ in signedness [-Wpointer-sign] if (strspn(addr, "0123456789-") == strlen(addr)) { ^ rsuplnk.c:106:6: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ rsuplnk.c:106:6: warning: pointer targets in passing argument 1 of ‘__strspn_c1’ differ in signedness [-Wpointer-sign] if (strspn(addr, "0123456789-") == strlen(addr)) { ^ In file included from /usr/include/string.h:634:0, from rsuplnk.c:2: /usr/include/bits/string2.h:1023:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ __strspn_c1 (const char *__s, int __accept) ^ rsuplnk.c:106:6: warning: pointer targets in passing argument 1 of ‘__strspn_c2’ differ in signedness [-Wpointer-sign] if (strspn(addr, "0123456789-") == strlen(addr)) { ^ In file included from /usr/include/string.h:634:0, from rsuplnk.c:2: /usr/include/bits/string2.h:1035:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ __strspn_c2 (const char *__s, int __accept1, int __accept2) ^ rsuplnk.c:106:6: warning: pointer targets in passing argument 1 of ‘__strspn_c3’ differ in signedness [-Wpointer-sign] if (strspn(addr, "0123456789-") == strlen(addr)) { ^ In file included from /usr/include/string.h:634:0, from rsuplnk.c:2: /usr/include/bits/string2.h:1047:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ __strspn_c3 (const char *__s, int __accept1, int __accept2, int __accept3) ^ rsuplnk.c:106:6: warning: pointer targets in passing argument 1 of ‘__builtin_strspn’ differ in signedness [-Wpointer-sign] if (strspn(addr, "0123456789-") == strlen(addr)) { ^ rsuplnk.c:106:6: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ rsuplnk.c:106:6: warning: pointer targets in passing argument 1 of ‘__builtin_strspn’ differ in signedness [-Wpointer-sign] if (strspn(addr, "0123456789-") == strlen(addr)) { ^ rsuplnk.c:106:6: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ rsuplnk.c:106:44: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] if (strspn(addr, "0123456789-") == strlen(addr)) { ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ rsuplnk.c:107:12: warning: pointer targets in passing argument 1 of ‘__builtin_strchr’ differ in signedness [-Wpointer-sign] if ((p = strchr(addr, '-')) != NULL) ^ rsuplnk.c:107:12: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ rsuplnk.c:107:11: warning: pointer targets in assignment differ in signedness [-Wpointer-sign] if ((p = strchr(addr, '-')) != NULL) ^ rsuplnk.c:109:19: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] switch (strlen(addr)) { ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ rsuplnk.c:128:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(buffer, "*** No ROSE address given\r"); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ rsuplnk.c:129:38: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] write(STDOUT_FILENO, buffer, strlen(buffer)); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ rsuplnk.c:195:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(buffer, "*** Connection in progress\r"); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ rsuplnk.c:196:38: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] write(STDOUT_FILENO, buffer, strlen(buffer)); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ rsuplnk.c:212:11: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(buffer, "*** Disconnected - 0100 - Number Busy\r"); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ rsuplnk.c:215:11: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(buffer, "*** Disconnected - 0D00 - Not Obtainable\r"); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ rsuplnk.c:218:11: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(buffer, "*** Disconnected - 3900 - Ship Absent\r"); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ rsuplnk.c:221:12: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign] sprintf(buffer, "*** Disconnected - %d - %s\r", errno, strerror(errno)); ^ In file included from rsuplnk.c:1:0: /usr/include/stdio.h:364:12: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern int sprintf (char *__restrict __s, ^ rsuplnk.c:228:39: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] write(STDOUT_FILENO, buffer, strlen(buffer)); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ rsuplnk.c:241:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(buffer, "*** Connected\r"); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ rsuplnk.c:242:38: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] write(STDOUT_FILENO, buffer, strlen(buffer)); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ rsuplnk.c:257:12: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign] strcpy(buffer, "\r*** Disconnected - 0000 - DTE Originated\r"); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’ extern char *strcpy (char *__restrict __dest, const char *__restrict __src) ^ rsuplnk.c:258:40: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign] write(STDOUT_FILENO, buffer, strlen(buffer)); ^ In file included from rsuplnk.c:2:0: /usr/include/string.h:398:15: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern size_t strlen (const char *__s) ^ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Reformat consistently. Strictly whitespace changes only.Ralf Baechle2013-06-171-22/+22
| | | | | | | Indentation by tabs only. Move case labels in switches are on the same level as the switch keyword. Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Nuke trailing whitespace.Ralf Baechle2013-06-171-2/+2
| | | | Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
* Remove use of backwards compatibility header name.Ralf Baechle2009-06-211-8/+0
| | | | | | Glibc as old as 2.2 provides working headers under the right name and if not libax25 would install headers under the right name so this has become redundant and ugly.
* Fix type of length argument to sockset syscalls.Ralf Baechle2009-06-141-1/+2
| | | | | | | | Various socket syscalls receive a length argument that should be a socklen_t rsp. a ptr to a socklen_t but instead int rsp. ptr to int were being passed. While in theory this was a bug it's harmless as dangerously large values would not be used but the issue manifested itself in a significant number of compilation warnings.
* buffer is 512. statement was:Thomas Osterried2008-10-221-1/+1
| | | | | | if ((n = read(s, buffer + 2, 512)) == -1) in rsdwnlnk.c if ((n = read(STDIN_FILENO, buffer + 2, 512)) == -1) in rsuplnk.c This smashes the buffer two bytes behind..
* Import ax25-tools 0.0.2 from tarballax25-tools-0.0.2Ralf Baechle1999-06-071-2/+10
|
* Import ax25-tools 0.0.1 from tarballax25-tools-0.0.1Ralf Baechle1999-04-211-0/+288