From e368a30edc4f4c28a5c7428dafd5f850335d18c8 Mon Sep 17 00:00:00 2001 From: Thomas Osterried Date: Wed, 22 Oct 2008 23:01:27 +0000 Subject: buffer is 512. statement was: if ((n = read(s, buffer + 2, 512)) == -1) in rsdwnlnk.c if ((n = read(STDIN_FILENO, buffer + 2, 512)) == -1) in rsuplnk.c This smashes the buffer two bytes behind.. --- rose/rsdwnlnk.c | 2 +- rose/rsuplnk.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rose/rsdwnlnk.c b/rose/rsdwnlnk.c index d4e4348..45950b3 100644 --- a/rose/rsdwnlnk.c +++ b/rose/rsdwnlnk.c @@ -247,7 +247,7 @@ int main(int argc, char **argv) select(s + 1, &read_fd, NULL, NULL, NULL); if (FD_ISSET(s, &read_fd)) { - if ((n = read(s, buffer + 2, 512)) == -1) + if ((n = read(s, buffer + 2, sizeof(buffer)-2)) == -1) break; if (buffer[2] == 0xF0) { buffer[2] = 0; diff --git a/rose/rsuplnk.c b/rose/rsuplnk.c index e9f5ecd..c6e99dd 100644 --- a/rose/rsuplnk.c +++ b/rose/rsuplnk.c @@ -275,7 +275,7 @@ int main(int argc, char **argv) } if (FD_ISSET(STDIN_FILENO, &read_fd)) { - if ((n = read(STDIN_FILENO, buffer + 2, 512)) == -1) { + if ((n = read(STDIN_FILENO, buffer + 2, sizeof(buffer)-2)) == -1) { close(s); break; } -- cgit v1.2.3