From f2736ed86e0b8372468be53d419e387056231e6b Mon Sep 17 00:00:00 2001 From: Ralf Baechle Date: Sun, 7 Jun 2015 00:41:53 +0200 Subject: ax25/mheardd.c: Fix signedness compiler warnings. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gcc -DHAVE_CONFIG_H -I. -I.. -DAX25_SYSCONFDIR=\""/usr/local/etc/ax25/"\" -DAX25_LOCALSTATEDIR=\""/usr/local/var/ax25/"\" -g -O2 -Wall -MT mheardd.o -MD -MP -MF .deps/mheardd.Tpo -c -o mheardd.o mheardd.c mheardd.c: In function ‘main’: mheardd.c:259:22: warning: pointer targets in passing argument 1 of ‘ax25_validate’ differ in signedness [-Wpointer-sign] if (!ax25_validate(data + 0) || !ax25_validate(data + AXLEN)) { ^ In file included from mheardd.c:31:0: /usr/include/netax25/axlib.h:116:12: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern int ax25_validate(const char *); ^ mheardd.c:259:50: warning: pointer targets in passing argument 1 of ‘ax25_validate’ differ in signedness [-Wpointer-sign] if (!ax25_validate(data + 0) || !ax25_validate(data + AXLEN)) { ^ In file included from mheardd.c:31:0: /usr/include/netax25/axlib.h:116:12: note: expected ‘const char *’ but argument is of type ‘unsigned char *’ extern int ax25_validate(const char *); ^ Signed-off-by: Ralf Baechle --- ax25/mheardd.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'ax25') diff --git a/ax25/mheardd.c b/ax25/mheardd.c index ec8cc2c..fa59131 100644 --- a/ax25/mheardd.c +++ b/ax25/mheardd.c @@ -89,7 +89,7 @@ static struct mheard_list_struct *mheard_list; static int mheard_list_size = MHEARD_LIST_SIZE/10; static int logging = FALSE; -static int ftype(unsigned char *, int *, int); +static int ftype(char *, int *, int); static struct mheard_list_struct *findentry(ax25_address *, char *); static void terminate(int sig) @@ -105,7 +105,8 @@ static void terminate(int sig) int main(int argc, char **argv) { struct mheard_list_struct *mheard; - unsigned char buffer[1500], *data; + char buffer[1500]; + char *data; int size, s; char *port = NULL; struct sockaddr sa; @@ -349,7 +350,9 @@ int main(int argc, char **argv) size -= ctlen; if (type == I || type == UI) { - switch (*data) { + unsigned char pid = *data; + + switch (pid) { case PID_TEXT: mheard->entry.mode |= MHEARD_MODE_TEXT; break; @@ -412,7 +415,7 @@ int main(int argc, char **argv) } } -static int ftype(unsigned char *data, int *type, int extseq) +static int ftype(char *data, int *type, int extseq) { if (extseq) { if ((*data & 0x01) == 0) { /* An I frame is an I-frame ... */ -- cgit v1.2.3