From 3ee1ebc7eebcbde2c47c4a92d9a400b172f32d91 Mon Sep 17 00:00:00 2001 From: Ralf Baechle Date: Tue, 1 Aug 2017 03:07:11 +0200 Subject: treewide: Remove useless casts from memcpy pointer arguments. This is using the following semantic patch: @memcpy1@ type T; expression A, B, C; @@ - memcpy((T *)A, B, C) + memcpy(A, B, C) @memcpy2@ type T; expression A, B, C; @@ - memcpy(A, (T *)B, C) + memcpy(A, B, C) Signed-off-by: Ralf Baechle --- tcpip/rip98r.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) (limited to 'tcpip/rip98r.c') diff --git a/tcpip/rip98r.c b/tcpip/rip98r.c index 2993666..6082e65 100644 --- a/tcpip/rip98r.c +++ b/tcpip/rip98r.c @@ -116,7 +116,7 @@ void receive_routes(int s) syslog(LOG_DEBUG, "RIP98 message received from %s\n", inet_ntoa(rem_addr.sin_addr)); for (p = message + RIP98_HEADER; p < message + mess_len; p += RIP98_ENTRY) { - memcpy((char *)&addr, (char *)p, sizeof(addr)); + memcpy(&addr, p, sizeof(addr)); bits = p[4]; metric = p[5]; @@ -211,7 +211,7 @@ void receive_routes(int s) trg.sin_family = AF_INET; trg.sin_addr = route->addr; trg.sin_port = 0; - memcpy((char *)&rt.rt_dst, (char *)&trg, sizeof(struct sockaddr)); + memcpy(&rt.rt_dst, &trg, sizeof(struct sockaddr)); if (ioctl(s, SIOCDELRT, &rt) < 0) { if (logging) @@ -227,7 +227,7 @@ void receive_routes(int s) trg.sin_family = AF_INET; trg.sin_addr = route->addr; trg.sin_port = 0; - memcpy((char *)&rt.rt_dst, (char *)&trg, sizeof(struct sockaddr)); + memcpy(&rt.rt_dst, &trg, sizeof(struct sockaddr)); rt.rt_flags = RTF_UP | RTF_GATEWAY | RTF_DYNAMIC; @@ -237,9 +237,11 @@ void receive_routes(int s) netmask = htonl(bits2mask(route->bits)); trg.sin_family = AF_INET; - memcpy((char *)&trg.sin_addr, (char *)&netmask, sizeof(struct in_addr)); + memcpy(&trg.sin_addr, &netmask, + sizeof(struct in_addr)); trg.sin_port = 0; - memcpy((char *)&rt.rt_genmask, (char *)&trg, sizeof(struct sockaddr)); + memcpy(&rt.rt_genmask, &trg, + sizeof(struct sockaddr)); } rt.rt_metric = route->metric + 1; @@ -247,7 +249,7 @@ void receive_routes(int s) trg.sin_family = AF_INET; trg.sin_addr = rem_addr.sin_addr; trg.sin_port = 0; - memcpy((char *)&rt.rt_gateway, (char *)&trg, sizeof(struct sockaddr)); + memcpy(&rt.rt_gateway, &trg, sizeof(struct sockaddr)); if (ioctl(s, SIOCADDRT, &rt) < 0) { if (logging) -- cgit v1.2.3