From daba307035faf4cc01f1ccb883b21281d91234cc Mon Sep 17 00:00:00 2001 From: Ralf Baechle Date: Fri, 28 Jul 2017 14:10:07 +0200 Subject: treewide: Kill assignments in if conditions. Somewhat hard to read and the code base already has many overlong lines. Found with below spatch file and some manual editing in ax25/access.c to restore a comment lost by spatch. @parens@ expression E, F, G; binary operator X; statement S; @@ - if ((E = F) X G) + E = F; + if (E X G) S Signed-off-by: Ralf Baechle --- yamdrv/yamcfg.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'yamdrv') diff --git a/yamdrv/yamcfg.c b/yamdrv/yamcfg.c index b14d6ff..7efb55a 100644 --- a/yamdrv/yamcfg.c +++ b/yamdrv/yamcfg.c @@ -320,7 +320,8 @@ int main (int argc, char *argv[]) strcpy (name, argv[1]); - if ((sock = socket (PF_INET, SOCK_PACKET, htons (ETH_P_AX25))) < 0) + sock = socket(PF_INET, SOCK_PACKET, htons(ETH_P_AX25)); + if (sock < 0) { fprintf (stderr, "%s: Error %s (%i), cannot open %s\n", argv[0], strerror (errno), errno, name); -- cgit v1.2.3