From cb4bd0ec8dcba856d1ebf8b3f72b79f669dad0f4 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Wed, 25 Aug 2010 09:04:55 -0700 Subject: Fix GRED options clearing Bug reported where priorities of GRED DP's are ignored. The option parsing sets opt then memset was clearing these values. --- tc/q_gred.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tc/q_gred.c b/tc/q_gred.c index df4aa3d8..59651d36 100644 --- a/tc/q_gred.c +++ b/tc/q_gred.c @@ -51,7 +51,7 @@ static int init_gred(struct qdisc_util *qu, int argc, char **argv, { struct rtattr *tail; - struct tc_gred_sopt opt; + struct tc_gred_sopt opt = { 0 }; int dps = 0; int def_dp = -1; @@ -83,7 +83,7 @@ static int init_gred(struct qdisc_util *qu, int argc, char **argv, return -1; } } else if (strcmp(*argv, "grio") == 0) { - opt.grio=1; + opt.grio = 1; } else if (strcmp(*argv, "help") == 0) { explain(); return -1; @@ -100,7 +100,6 @@ static int init_gred(struct qdisc_util *qu, int argc, char **argv, return -1; } - memset(&opt, 0, sizeof(struct tc_gred_sopt)); opt.DPs = dps; opt.def_DP = def_dp; -- cgit v1.2.3