summaryrefslogtreecommitdiffstats
path: root/net/core
diff options
context:
space:
mode:
authorRalf Baechle <ralf@linux-mips.org>1998-03-03 01:22:27 +0000
committerRalf Baechle <ralf@linux-mips.org>1998-03-03 01:22:27 +0000
commitf9bbe9da79dbc8557c74efeb158b431cd67ace52 (patch)
tree3220d014a35f9d88a48668a1468524e988daebff /net/core
parent3d697109c1ff85ef563aec3d5e113ef225ed2792 (diff)
Upgrade to 2.1.73.
Diffstat (limited to 'net/core')
-rw-r--r--net/core/iovec.c16
1 files changed, 14 insertions, 2 deletions
diff --git a/net/core/iovec.c b/net/core/iovec.c
index 10aa7a4cc..bff328b19 100644
--- a/net/core/iovec.c
+++ b/net/core/iovec.c
@@ -13,6 +13,7 @@
* csum_..._fromiovecend.
* Andi Kleen : fixed error handling for 2.1
* Alexey Kuznetsov: 2.1 optimisations
+ * Andi Kleen : Fix csum*fromiovecend for IPv6.
*/
@@ -196,7 +197,7 @@ int memcpy_fromiovecend(unsigned char *kdata, struct iovec *iov, int offset,
int csum_partial_copy_fromiovecend(unsigned char *kdata,
struct iovec *iov, int offset,
- int len, int *csump)
+ unsigned int len, int *csump)
{
int partial_cnt = 0;
int err = 0;
@@ -238,7 +239,15 @@ int csum_partial_copy_fromiovecend(unsigned char *kdata,
while (len>0)
{
u8 *base = iov->iov_base;
- int copy = min(len, iov->iov_len);
+ unsigned int copy = min(len, iov->iov_len);
+
+ /* FIXME: more sanity checking is needed here, because
+ * the iovs are copied from the user.
+ */
+ if (base == NULL) {
+ printk(KERN_DEBUG "%s: iov too short\n",current->comm);
+ return -EINVAL;
+ }
/* There is a remnant from previous iov. */
if (partial_cnt)
@@ -277,6 +286,9 @@ int csum_partial_copy_fromiovecend(unsigned char *kdata,
}
}
+ if (copy == 0)
+ break;
+
csum = csum_partial_copy_from_user(base, kdata, copy, csum, &err);
len -= copy + partial_cnt;
kdata += copy + partial_cnt;