listen: Fix signedness compiler warnings.

make[2]: Entering directory '/home/ralf/src/ax25/ax25-apps/listen'
gcc -DHAVE_CONFIG_H -I. -I..     -g -O2 -Wall -MT listen.o -MD -MP -MF .deps/listen.Tpo -c -o listen.o listen.c
listen.c: In function ‘ascii_dump’:
listen.c:231:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncat’ differ in signedness [-Wpointer-sign]
     strncat(buf, &c, 1);
    ^
listen.c:231:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
listen.c: In function ‘hex_dump’:
listen.c:282:8: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
  data2 = data;
        ^
[...]
gcc -DHAVE_CONFIG_H -I. -I..     -g -O2 -Wall -MT rosedump.o -MD -MP -MF .deps/rosedump.Tpo -c -o rosedump.o rosedump.c
rosedump.c: In function ‘facility’:
rosedump.c:331:9: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
  factot = data;
         ^
rosedump.c:398:11: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
    for (d = data, l = 0; l < lgaddcall;
           ^
rosedump.c:406:28: warning: pointer targets in passing argument 1 of ‘dump_ax25_call’ differ in signedness [-Wpointer-sign]
             dump_ax25_call(d, 7));
                            ^
rosedump.c:296:14: note: expected ‘unsigned char *’ but argument is of type ‘char *’
 static char *dump_ax25_call(unsigned char *data, int l_data)
              ^
rosedump.c:410:28: warning: pointer targets in passing argument 1 of ‘dump_ax25_call’ differ in signedness [-Wpointer-sign]
             dump_ax25_call(d, 7));
                            ^
rosedump.c:296:14: note: expected ‘unsigned char *’ but argument is of type ‘char *’
 static char *dump_ax25_call(unsigned char *data, int l_data)
              ^
rosedump.c:438:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
     strncpy(indorig, data, lgadind);
    ^
rosedump.c:438:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
rosedump.c:441:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
     strncpy(inddest, data, lgadind);
    ^
rosedump.c:441:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
rosedump.c:451:14: warning: pointer targets in passing argument 1 of ‘data_dump’ differ in signedness [-Wpointer-sign]
    data_dump(factot, lgtot, 1);
              ^
In file included from rosedump.c:11:0:
listen.h:31:6: note: expected ‘unsigned char *’ but argument is of type ‘char *’
 void data_dump(unsigned char *, int, int);
      ^
[...]
gcc -DHAVE_CONFIG_H -I. -I..     -g -O2 -Wall -MT utils.o -MD -MP -MF .deps/utils.Tpo -c -o utils.o utils.c
utils.c: In function ‘lprintf’:
utils.c:49:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
   for (p = str; *p != '\0'; p++) {
          ^
utils.c:71:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
   for (p = str; *p != '\0'; p++)
          ^
[...]
make[2]: Leaving directory '/home/ralf/src/ax25/ax25-apps/listen'

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

4 files changed, 8 insertions, 8 deletions

diff --git a/listen/listen.c b/listen/listen.c
index 11f365e..bf60281 100644
--- a/listen/listen.c
+++ b/listen/listen.c
@@ -216,7 +216,7 @@ int main(int argc, char **argv)
 
 static void ascii_dump(unsigned char *data, int length)
 {
-	unsigned char c;
+	char c;
 	int i, j;
 	char buf[100];
 
@@ -272,9 +272,9 @@ static void readable_dump(unsigned char *data, int length)
 
 static void hex_dump(unsigned char *data, int length)
 {
+	unsigned char *data2;
 	int i, j, length2;
 	unsigned char c;
-	char *data2;
 
 	char buf[4], hexd[49], ascd[17];
 
@@ -309,7 +309,7 @@ static void hex_dump(unsigned char *data, int length)
 	}
 }
 
-void data_dump(unsigned char *data, int length, int dumpstyle)
+void data_dump(void *data, int length, int dumpstyle)
 {
 	switch (dumpstyle) {
 
diff --git a/listen/listen.h b/listen/listen.h
index 73a5d06..841a494 100644
--- a/listen/listen.h
+++ b/listen/listen.h
@@ -28,7 +28,7 @@ int  initcolor(void);
 char *servname(int port, char *proto);
 
 /* In listen.c */
-void data_dump(unsigned char *, int, int);
+void data_dump(void *, int, int);
 int  get16(unsigned char *);
 int  get32(unsigned char *);
 
diff --git a/listen/rosedump.c b/listen/rosedump.c
index c9beaee..e8f8fdc 100644
--- a/listen/rosedump.c
+++ b/listen/rosedump.c
@@ -324,7 +324,7 @@ static void facility(unsigned char *data, int lgtot)
 	char digis[80], digid[80];
 	char indorig[10], inddest[10];
 	char addstorig[20], addstdest[20];
-	char *d, *factot;
+	unsigned char *d, *factot;
 	char buf[512];
 	char *result = buf;
 
@@ -435,10 +435,10 @@ static void facility(unsigned char *data, int lgtot)
 			lgadind = lgaddcall - (lgad + 1) / 2 - 5;
 
 			if (fct == 0xCB) {
-				strncpy(indorig, data, lgadind);
+				strncpy(indorig, (char *)data, lgadind);
 				indorig[lgadind] = '\0';
 			} else {
-				strncpy(inddest, data, lgadind);
+				strncpy(inddest, (char *)data, lgadind);
 				inddest[lgadind] = '\0';
 			}
 
diff --git a/listen/utils.c b/listen/utils.c
index 8f522e5..667bab7 100644
--- a/listen/utils.c
+++ b/listen/utils.c
@@ -38,8 +38,8 @@ void lprintf(int dtype, char *fmt, ...)
 {
 	va_list args;
 	char str[1024];
-	unsigned char *p;
 	chtype ch;
+	char *p;
 
 	va_start(args, fmt);
 	vsnprintf(str, 1024, fmt, args);