| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
| |
tcpdump.
-> Without -t, listen now shows a timestamp.
Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
|
|
|
|
|
|
|
| |
has_colors() was called before initscr().
also added error message if terminal does not support colors (and then exit).
Signed-off-by: root <root@db0fhn.ampr.org>
|
|
|
|
|
|
|
|
| |
tcpdump.
-> Without -t, listen now shows a timestamp.
Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
packet, but garbled:
bpq2: fm DL9SAU to DL9SAU-15 ctl I00+ pid=8(segment) len 4 remain 0
0000 E2 E3 E4 | ...
Reason:
the defragmented packet is passed to netif_rx(skb).
It has skb->protocol = htons(ETH_P_IP), but still belongs to
ifr.ifr_hwaddr.sa_family == AF_AX25.
listen -a looks for every iface with like ifr.ifr_hwaddr.sa_family == AF_AX25
and thus gets the desegmented packet. This desegmented packet has already
lost his ax25 header information (it's the IP datagram that netif_rx sees),
prefixed by AX25_P_IP = 0xcc:
strace:
recvfrom(3, "\0\210\230r\246\202\252\340\210\230r\246\202\252\177\314\10\201\314E\0\1\1\0\32\0\0?\1!\327,\200\200\n,\200\200\1\0\0\347\300\21\6\0\1\26\23\303V..
recvfrom(3, "\314E\0\1\1\0\32\0\0?\1!\327,\200\200\n,\200\200\1\0\0\347\300\21\6\0\1\26\23\303V..
\314 == 0xcc == AX25_P_IP
We can make safely make the assumption for first byte == 0xcc and length > 2,
that we safeley can detect those IP frames, and then ignore it.
Signed-off-by: Thomas Osterried <ax25@x-berg.in-berlin.de>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
make[2]: Entering directory '/home/ralf/src/ax25/ax25-apps/listen'
gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT listen.o -MD -MP -MF .deps/listen.Tpo -c -o listen.o listen.c
listen.c: In function ‘ascii_dump’:
listen.c:231:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncat’ differ in signedness [-Wpointer-sign]
strncat(buf, &c, 1);
^
listen.c:231:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
listen.c: In function ‘hex_dump’:
listen.c:282:8: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
data2 = data;
^
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT rosedump.o -MD -MP -MF .deps/rosedump.Tpo -c -o rosedump.o rosedump.c
rosedump.c: In function ‘facility’:
rosedump.c:331:9: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
factot = data;
^
rosedump.c:398:11: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
for (d = data, l = 0; l < lgaddcall;
^
rosedump.c:406:28: warning: pointer targets in passing argument 1 of ‘dump_ax25_call’ differ in signedness [-Wpointer-sign]
dump_ax25_call(d, 7));
^
rosedump.c:296:14: note: expected ‘unsigned char *’ but argument is of type ‘char *’
static char *dump_ax25_call(unsigned char *data, int l_data)
^
rosedump.c:410:28: warning: pointer targets in passing argument 1 of ‘dump_ax25_call’ differ in signedness [-Wpointer-sign]
dump_ax25_call(d, 7));
^
rosedump.c:296:14: note: expected ‘unsigned char *’ but argument is of type ‘char *’
static char *dump_ax25_call(unsigned char *data, int l_data)
^
rosedump.c:438:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
strncpy(indorig, data, lgadind);
^
rosedump.c:438:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
rosedump.c:441:4: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
strncpy(inddest, data, lgadind);
^
rosedump.c:441:4: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
rosedump.c:451:14: warning: pointer targets in passing argument 1 of ‘data_dump’ differ in signedness [-Wpointer-sign]
data_dump(factot, lgtot, 1);
^
In file included from rosedump.c:11:0:
listen.h:31:6: note: expected ‘unsigned char *’ but argument is of type ‘char *’
void data_dump(unsigned char *, int, int);
^
[...]
gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT utils.o -MD -MP -MF .deps/utils.Tpo -c -o utils.o utils.c
utils.c: In function ‘lprintf’:
utils.c:49:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
for (p = str; *p != '\0'; p++) {
^
utils.c:71:10: warning: pointer targets in assignment differ in signedness [-Wpointer-sign]
for (p = str; *p != '\0'; p++)
^
[...]
make[2]: Leaving directory '/home/ralf/src/ax25/ax25-apps/listen'
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -g -O2 -Wall -MT opentracdump.o -MD -MP -MF .deps/opentracdump.Tpo -c -o opentracdump.o opentracdump.c
opentracdump.c: In function ‘decode_origination’:
opentracdump.c:70:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(entity_call, origin_call);
^
In file included from opentracdump.c:9:0:
/usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
opentracdump.c:70:22: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(entity_call, origin_call);
^
In file included from opentracdump.c:9:0:
/usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
opentracdump.c: In function ‘decode_entityid’:
opentracdump.c:86:10: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(entity_call, origin_call);
^
In file included from opentracdump.c:9:0:
/usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
opentracdump.c:86:23: warning: pointer targets in passing argument 2 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(entity_call, origin_call);
^
In file included from opentracdump.c:9:0:
/usr/include/string.h:129:14: note: expected ‘const char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
opentracdump.c: In function ‘decode_comment’:
opentracdump.c:159:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
strncpy(comment, element, element_len);
^
opentracdump.c:159:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
opentracdump.c: In function ‘decode_country’:
opentracdump.c:195:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
strncpy(country, element, 2);
^
opentracdump.c:195:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
opentracdump.c:198:2: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
strncpy(subdivision, element+2, element_len-2);
^
opentracdump.c:198:2: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
opentracdump.c: In function ‘decode_displayname’:
opentracdump.c:211:5: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
strncpy(displayname, element, element_len);
^
opentracdump.c:211:5: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
opentracdump.c: In function ‘decode_waypoint’:
opentracdump.c:221:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
strncpy(waypoint, element, element_len);
^
opentracdump.c:221:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
opentracdump.c: In function ‘decode_pathtrace’:
opentracdump.c:255:23: warning: pointer targets in passing argument 1 of ‘extract_ssid’ differ in signedness [-Wpointer-sign]
ssid = extract_ssid(callsign);
^
opentracdump.c:30:5: note: expected ‘unsigned char *’ but argument is of type ‘char *’
int extract_ssid(unsigned char *call) {
^
opentracdump.c: In function ‘decode_acreg’:
opentracdump.c:315:1: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
strncpy(nnumber, element, element_len);
^
opentracdump.c:315:1: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
opentracdump.c: In function ‘decode_maidenhead’:
opentracdump.c:406:3: warning: pointer targets in passing argument 2 of ‘__builtin_strncpy’ differ in signedness [-Wpointer-sign]
strncpy(maidenhead, element, element_len);
^
opentracdump.c:406:3: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
opentracdump.c: In function ‘opentrac_dump’:
opentracdump.c:452:9: warning: pointer targets in passing argument 1 of ‘strcpy’ differ in signedness [-Wpointer-sign]
strcpy(origin_call, "SENDER"); /* Listen doesn't tell us the sender */
^
In file included from opentracdump.c:9:0:
/usr/include/string.h:129:14: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
extern char *strcpy (char *__restrict __dest, const char *__restrict __src)
^
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
Indentation by tabs only. Move case labels in switches are on the same
level as the switch keyword.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -O2 -Wall -Wno-pointer-sign -MT ax25dump.o -MD
-MP -MF .deps/ax25dump.Tpo -c -o ax25dump.o ax25dump.c
ax25dump.c: In function ‘ax25_dump’:
ax25dump.c:170:10: warning: ‘ns’ may be used uninitialized in this function [-Wmaybe-uninitialized]
ax25dump.c:167:10: warning: ‘nr’ may be used uninitialized in this function [-Wmaybe-uninitialized]
GCC isn't quite smart enough to figure out that this warning is bogus.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
|
| |
gcc -DHAVE_CONFIG_H -I. -I.. -O2 -Wall -Wno-pointer-sign -MT rosedump.o -MD -MP -MF .deps/rosedump.Tpo -c -o rosedump.o rosedump.c
rosedump.c: In function ‘rose_dump’:
rosedump.c:57:17: warning: variable ‘dest’ set but not used [-Wunused-but-set-va riable]
rosedump.c:56:17: warning: variable ‘source’ set but not used [-Wunused-but-set- variable]
rosedump.c: In function ‘facility’:
rosedump.c:329:12: warning: variable ‘lgaddr’ set but not used [-Wunused-but-set -variable]
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
|
|
|
| |
It was testing the address of the curses function has_color(), not its
return value indicated by the following warning:
utils.c: In function ‘initcolor’:
utils.c:84:6: warning: the address of ‘has_colors’ will always evaluate as ‘true’ [-Waddress]
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
|
|
|
| |
Their value has always been dubious and git doesn't support them so let's
get rid of the clutter.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
|
|
|
| |
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
|
| |
|
|
|
|
| |
Relicense listen/ripdump.c to permit commercial use and distribution.
|
|
|
|
|
|
| |
For now these options are just honored for the call.1 and listen.1 man
pages because these days these two programs generally get renamed to
avoid naming conflicts with other programs.
|
|
|
|
|
|
|
|
|
|
|
|
| |
GIFADDR: Bad file descriptor
after signling termination with ^C
In detail:
close(3) = 0
sigreturn() = ? (mask now [])
ioctl(3, SIOCGIFHWADDR, {ifr_name="eth0", ???}) = -1 EBADF (Bad file descriptor)
-> The interrupt handler introduced concurrency issues ;)
The patch caused only unexpected behaviour; no security problems.
This new patch fixes this problem.
|
|
|
|
| |
Patch from Michael Stuermer <ms@mallorn.de> with a few touchups be me.
|
|
|
|
|
|
| |
Glibc as old as 2.2 provides working headers under the right name and
if not libax25 would install headers under the right name so this has
become redundant and ugly.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keeping generated files in CVS doesn't only tend to produce large and
cluttered files it also may result in build problems due to timestamps
in the wrong order. So dump everything, update .cvsignore to ignore
these files and resolve all warnings generated by autoreconf.
From now on users of a CVS checkout should run the command
autoreconf --install --force
after having done a CVS checkout. For this to succeed automake, autoconf
and libtool will have to be installed.
|
|
|
|
|
|
|
|
| |
Various socket syscalls receive a length argument that should be a
socklen_t rsp. a ptr to a socklen_t but instead int rsp. ptr to int were
being passed. While in theory this was a bug it's harmless as dangerously
large values would not be used but the issue manifested itself in a
significant number of compilation warnings.
|
|
|
|
|
| |
Any modern C compiler will just ignore register so it's just cluttering
the screen.
|
|
|
|
| |
and warnings.
|
|
|
|
| |
return value EOF was not honored.
|
| |
|
| |
|
|
|
|
| |
pointless comments.
|
| |
|
| |
|
|
|
|
| |
More autobbreak updating nightmares
|
| |
|
| |
|
| |
|
|
|
|
| |
* Added \n to poll line
|
| |
|
|
|
|
| |
Makefile bug
|
| |
|
| |
|
| |
|
| |
|
|
|