diff options
| author | Ralf Baechle <ralf@linux-mips.org> | 2017-07-28 14:10:07 +0200 |
|---|---|---|
| committer | Ralf Baechle <ralf@linux-mips.org> | 2017-07-31 04:29:44 +0200 |
| commit | daba307035faf4cc01f1ccb883b21281d91234cc (patch) | |
| tree | edbd5df9285303f281524fac8064866057ce35ce /ax25/access.c | |
| parent | 71b0582584ac5de97141ea207ddf17f7c938b2df (diff) | |
treewide: Kill assignments in if conditions.
Somewhat hard to read and the code base already has many overlong
lines.
Found with below spatch file and some manual editing in ax25/access.c
to restore a comment lost by spatch.
@parens@
expression E, F, G;
binary operator X;
statement S;
@@
- if ((E = F) X G)
+ E = F;
+ if (E X G)
S
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
Diffstat (limited to 'ax25/access.c')
| -rw-r--r-- | ax25/access.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/ax25/access.c b/ax25/access.c index 951830c..2ecbb1d 100644 --- a/ax25/access.c +++ b/ax25/access.c @@ -204,7 +204,9 @@ static void write_example_passwd(char *pwfile, char pwlocation, FILE * f; int i; - if ((i = open(pwfile, O_CREAT|O_WRONLY|O_TRUNC, (S_IRUSR | S_IWUSR | (pwlocation == SYSTEMPW ? (S_IRGRP /* | S_IWGRP */ ) : 0)))) == -1) + i = open(pwfile, O_CREAT | O_WRONLY | O_TRUNC, + (S_IRUSR | S_IWUSR | (pwlocation == SYSTEMPW ? (S_IRGRP /* | S_IWGRP */) : 0))); + if (i == -1) return; fchown(i, (pwlocation == SYSTEMPW ? 0 : pw->pw_uid), (pwlocation == SYSTEMPW ? 0 : pw->pw_gid)); close(i); |