Delete more assignments in if conditions.

Based on below coccinelle script with a bad transformation fixed up
manually.

@if1@
expression E, F, G;
binary operator X;
statement S;
@@
-	if ((E = F) X G)
+	E = F;
+	if (E X G)
		S
@if2@
expression E, F, G;
binary operator X;
statement S;
@@
-	if (G X (E = F))
+	E = F;
+	if (E X G)
		S
@if3@
expression E, F;
statement S;
@@
-	if (!(E = F))
+	E = F;
+	if (!E)
		S
@if4@
expression E, F;
statement S;
@@
-	if ((E = F))
+	E = F;
+	if (E)
		S

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

1 files changed, 10 insertions, 5 deletions

diff --git a/ax25/axgetput/util.c b/ax25/axgetput/util.c
index a4a83c0..69adb60 100644
--- a/ax25/axgetput/util.c
+++ b/ax25/axgetput/util.c
@@ -116,19 +116,23 @@ char *get_fixed_filename(char *line, long size, unsigned int msg_crc, int genera
 
   *filename = 0;
 
-  if ((p = strchr(line, '\"'))) {
+  p = strchr(line, '\"');
+  if (p) {
     p++;
   }
 
   /* security.. */
 
-  if ((q = strrchr((p ? p : line), '/'))) {
+  q = strrchr((p ? p : line), '/');
+  if (q) {
     p = ++q;
   }
-  if ((q = strrchr((p ? p : line), '\\'))) {
+  q = strrchr((p ? p : line), '\\');
+  if (q) {
     p = ++q;
   }
-  if ((q = strrchr((p ? p : line), ':'))) {
+  q = strrchr((p ? p : line), ':');
+  if (q) {
     p = ++q;
   }
   if (!p) {
@@ -144,7 +148,8 @@ char *get_fixed_filename(char *line, long size, unsigned int msg_crc, int genera
   }
   *r = 0;
   strtrim(filename);
-  if ((q = strrchr(filename, '.'))) {
+  q = strrchr(filename, '.');
+  if (q) {
     if (!*(q+1)) {
       /* remove trailing dots */
       *q = 0;