treewide: Kill assignments in if conditions.

Somewhat hard to read and the code base already has many overlong
lines.

Found with below spatch file and some manual editing in ax25/access.c
to restore a comment lost by spatch.

@parens@
expression E, F, G;
binary operator X;
statement S;
@@
-	if ((E = F) X G)
+	E = F;
+	if (E X G)
		S

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

1 files changed, 2 insertions, 1 deletions

diff --git a/kiss/kissparms.c b/kiss/kissparms.c
index def7b59..7834162 100644
--- a/kiss/kissparms.c
+++ b/kiss/kissparms.c
@@ -153,7 +153,8 @@ int main(int argc, char *argv[])
 		return 1;
 	}
 
-	if ((s = socket(PF_PACKET, SOCK_PACKET, htons(proto))) < 0) {
+	s = socket(PF_PACKET, SOCK_PACKET, htons(proto));
+	if (s < 0) {
 		perror("kissparms: socket");
 		return 1;
 	}